Page MenuHomePhabricator
Create Task
Maniphest T328428

Vuex store: Add tests for the new Zobject module methods.
Closed, ResolvedPublic
Actions

Description

Description

Add tests for the new methods added to the zobject module that will be preserved for DefaultView:

Getters:

  • getRowById
  • getZObjectKeyByRowId
  • getZObjectValueByRowId
  • getChildrenByParentRowId
  • getRowByKeyPath
  • getZObjectTerminalValue
  • getZFunctionCallFunctionId
  • getZFunctionCallArguments
  • getZFunctionArgumentDeclarations
  • getZTypeStringRepresentation
  • getTypedListItemType
  • getZPersistentContentRowId
  • getZPersistentNameLangs
  • getZPersistentName
  • getZPersistentDescriptionLangs
  • getZPersistentDescription
  • getZPersistentAliasLangs
  • getZPersistentAlias
  • getMetadataLanguages
  • getZImplementationFunctionRowId
  • getZImplementationFunctionZid
  • getZImplementationContentType
  • getZImplementationContentRowId
  • getZCodeProgrammingLanguage
  • getZCodeString
  • getZStringTerminalValue
  • getZReferenceTerminalValue
  • getZMonolingualTextValue
  • getZMonolingualLangValue
  • getZMonolingualStringsetValues
  • getZMonolingualStringsetLang
  • getZMultilingualLanguageList
  • getZBooleanValue
  • getZObjectTypeByRowId
  • getDepthByRowId
  • getParentRowId
  • getNextRowId
  • isInsideComposition

Actions:

  • injectZObjectFromRowId
  • injectKeyValueFromRowId
  • setZFunctionCallArguments
  • setZImplementationContentType
  • setValueByRowIdAndPath
  • setValueByRowId
  • removeItemFromTypedList
  • removeAllItemsFromTypedList

Completion checklist

Details

SubjectRepoBranchLines +/-
Feat: Vuex store: Add tests for the new Zobject module methods.mediawiki/extensions/WikiLambdamaster+579 -15
Feat: Vuex store: Add tests for the new Zobject module methods.mediawiki/extensions/WikiLambdamaster+177 -1
Add Row class and use in zobjectTree and zobject modulesmediawiki/extensions/WikiLambdamaster+753 -158
Customize query in gerrit

Event Timeline

gengh created this task.Jan 31 2023, 11:59 AM
gengh claimed this task.Feb 1 2023, 3:58 PM
gerritbot added a comment.Feb 7 2023, 1:06 PM

Change 886377 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add Row class and use in zobjectTree and zobject modules

https://gerrit.wikimedia.org/r/886377

gerritbot added a project: Patch-For-Review.Feb 7 2023, 1:06 PM
gengh updated the task description. (Show Details)Feb 7 2023, 1:08 PM
gerritbot added a comment.Feb 7 2023, 6:30 PM

Change 886377 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add Row class and use in zobjectTree and zobject modules

https://gerrit.wikimedia.org/r/886377

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 6:30 PM
Jdforrester-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Feb 7 2023, 7:45 PM
Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 12:53 AM
gengh updated the task description. (Show Details)Apr 4 2023, 11:20 AM
gengh updated the task description. (Show Details)
gengh updated the task description. (Show Details)Apr 4 2023, 11:22 AM
gengh updated the task description. (Show Details)
gerritbot added a comment.Apr 6 2023, 8:16 AM

Change 906531 had a related patch set uploaded (by AllanJeremy (ThisDot); author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] Feat: Vuex store: Add tests for the new Zobject module methods.

https://gerrit.wikimedia.org/r/906531

gerritbot added a project: Patch-For-Review.Apr 6 2023, 8:16 AM
gerritbot added a comment.Apr 14 2023, 5:40 PM

Change 906531 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Feat: Vuex store: Add tests for the new Zobject module methods.

https://gerrit.wikimedia.org/r/906531

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 14 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 14 2023, 6:10 PM
gengh updated the task description. (Show Details)Apr 19 2023, 7:05 AM
gengh updated the task description. (Show Details)
gengh updated the task description. (Show Details)May 12 2023, 4:43 PM
gengh updated the task description. (Show Details)May 16 2023, 10:55 AM
allanjeremy.thisdot claimed this task.May 17 2023, 12:19 PM
gerritbot added a comment.May 23 2023, 2:37 PM

Change 922550 had a related patch set uploaded (by AllanJeremy (ThisDot); author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] Feat: Vuex store: Add tests for the new Zobject module methods.

https://gerrit.wikimedia.org/r/922550

gerritbot added a project: Patch-For-Review.May 23 2023, 2:37 PM
gerritbot added a comment.May 31 2023, 7:28 AM

Change 922550 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Feat: Vuex store: Add tests for the new Zobject module methods.

https://gerrit.wikimedia.org/r/922550

Maintenance_bot removed a project: Patch-For-Review.May 31 2023, 7:30 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).May 31 2023, 8:00 AM
allanjeremy.thisdot updated the task description. (Show Details)Jun 1 2023, 11:35 AM
Jdforrester-WMF removed allanjeremy.thisdot as the assignee of this task.Jun 26 2023, 4:51 PM
Jdforrester-WMF added a subscriber: allanjeremy.thisdot.
gengh claimed this task.Sep 1 2023, 1:24 PM
gengh updated the task description. (Show Details)
gengh moved this task from To triage: Nice-to-haves to Verify in production on the Abstract Wikipedia team board.
DVrandecic closed this task as Resolved.Sep 27 2023, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL