| guergana.tzatchkova | |
| Feb 13 2023, 10:20 AM |
| F36864738: image.png | |
| Feb 22 2023, 10:41 AM |
Implement the first three steps of the parent task:
Note: there is also a columns prop that takes 'one' or 'three' as input
This PoC can be used as a base to build the component.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Arian_Bozorg | T328764 Implement custom LanguageSelector component | |||
| Resolved | guergana.tzatchkova | T329487 QueryBuilder: Create basic one column LanguageSelector component |
Outcome of the exploration done as part of T324653: investigate language switching in the UI for our single page applications: https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/875287/
Change 889547 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):
[wikidata/query-builder@master] Add markup and styles for LanguageSelector component
Change 889966 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Manage language filtering inside LanguageSelector
Change 890395 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Use actual <button> for clear button
Change 890396 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[wikidata/query-builder@master] Proposal: Make clearBtnVisible computed
Change 889966 abandoned by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Manage language filtering inside LanguageSelector
Reason:
squashed into I507187e081
Change 890395 abandoned by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Use actual <button> for clear button
Reason:
squashed into I507187e081
Change 890396 abandoned by Lucas Werkmeister (WMDE):
[wikidata/query-builder@master] Proposal: Make clearBtnVisible computed
Reason:
squashed into I507187e081
@Arian_Borzog @karapayneWMDE Please check the visual implementation of the base elements of the component LanguageSelector. The component has been added to the screen for now just so you can review it, but it will be not be merged into the code. The component will be added with the button and correct position in another task: T328148 . Please note that this version doesn't include the mobile version, keyboard navigation or RTL behaviour, those features will be added in subsequent tasks.
https://889547--clicky-sparqly.netlify.app/
Hi @guergana.tzatchkova :)
Just a couple of sizing amendments on this.
It looks like the padding on the bottom of the search is a little too high, it should be 16px.
Here is a screenshot to illustrate:
And it looks like the dimensions of the search box are a little off too, it should be 384 x 52px.
I think the height will be fixed when the padding is amended.
The rest looks great!
Thanks so much :)
Change 889547 merged by jenkins-bot:
[wikidata/query-builder@master] Add markup and styles for LanguageSelector component