Maniphest T329494

Replace usage of deprecated ActorMigration in AbstractCheckUserPager
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 13 2023, 10:42 AM

Tags

Referenced Files

None

Subscribers

Description

The AbstractCheckUserPager still uses the deprecated ActorMigration class to generate the message shown when no results are present for a target. This is for a join to the revision table which has completed it's actor migration. This should be removed and replaced with a join to the actor table like is done for a select on the logging table.

Details

	Subject	Repo	Branch	Lines +/-
	Remove usage of ActorMigration	mediawiki/extensions/CheckUser	master	+20 -49

Customize query in gerrit

Related Objects

Mentioned Here: T215466: Remove revision_comment_temp and revision_actor_temp

Event Timeline

Dreamy_Jazz created this task.Feb 13 2023, 10:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2023, 10:42 AM

Dreamy_Jazz triaged this task as Low priority.Feb 13 2023, 10:43 AM

Dreamy_Jazz moved this task from Inbox to CheckUser on the CheckUser board.

Dreamy_Jazz added a parent task: T233004: Update CheckUser for actor and comment table.

Dreamy_Jazz updated the task description. (Show Details)Feb 13 2023, 10:46 AM

Dreamy_Jazz added a parent task: T275246: Populate rev_actor and rev_comment_id.Feb 13 2023, 11:37 AM

Izno removed a parent task: T233004: Update CheckUser for actor and comment table.Mar 14 2023, 5:50 PM

Izno edited parent tasks, added: T215466: Remove revision_comment_temp and revision_actor_temp; removed: T275246: Populate rev_actor and rev_comment_id.Jun 7 2023, 5:17 PM

This is not really a blocker of T215466: Remove revision_comment_temp and revision_actor_temp, removed as parent.

Change 996607 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Remove usage of ActorMigration

https://gerrit.wikimedia.org/r/996607

gerritbot added a project: Patch-For-Review.Feb 4 2024, 11:37 PM

Dreamy_Jazz assigned this task to Zabe.Feb 5 2024, 11:14 AM

Change 996607 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove usage of ActorMigration

https://gerrit.wikimedia.org/r/996607

Dreamy_Jazz closed this task as Resolved.Feb 5 2024, 11:36 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 5 2024, 3:01 PM