Page MenuHomePhabricator
Create Task
Maniphest T329515

jsonschema-tools tests - ensure that array items type is set
Closed, ResolvedPublic
Actions

Description

In this schema patch, CI passed even though the rejection_reasons array items did not specific a type. This caused some downstream systems to break.

This was fixed by adding a type.

*Done is*

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add robustness test for array items typerepos/data-engineering/jsonschema-tools!41ebysansgithub/fork/ottomata/array_items_typemaster
Customize query in GitLab

Event Timeline

Ottomata created this task.Feb 13 2023, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2023, 1:46 PM
JArguello-WMF edited projects, added: Data-Engineering-Planning; removed: Data-Engineering.Feb 17 2023, 6:37 PM
JArguello-WMF moved this task from Backlog to Event Platform on the Data-Engineering-Planning board.Feb 17 2023, 6:38 PM
Ottomata moved this task from Backlog to To be Estimated/To be discussed on the Event-Platform board.Mar 8 2023, 3:02 PM
JArguello-WMF triaged this task as Medium priority.Mar 8 2023, 3:10 PM
JArguello-WMF updated the task description. (Show Details)
• lbowmaker moved this task from To be Estimated/To be discussed to Backlog on the Event-Platform board.Apr 19 2023, 3:13 PM
• lbowmaker moved this task from Backlog to Sprint 14 A on the Event-Platform board.May 10 2023, 1:23 PM
• lbowmaker edited projects, added: Event-Platform (Sprint 14 A); removed: Event-Platform.
Ottomata added a comment.May 24 2023, 6:37 PM

PR here: https://github.com/wikimedia/jsonschema-tools/pull/41

@tchin could you review ^ ?

Ottomata claimed this task.May 24 2023, 6:38 PM
Ottomata updated the task description. (Show Details)
Ottomata moved this task from Next Up to In Review on the Event-Platform (Sprint 14 A) board.
Ottomata moved this task from In Review to In progress on the Event-Platform (Sprint 14 A) board.
Ottomata moved this task from In progress to In Review on the Event-Platform (Sprint 14 A) board.May 25 2023, 8:33 PM
JArguello-WMF edited projects, added: Event-Platform (Sprint 14 B); removed: Event-Platform (Sprint 14 A).Jun 5 2023, 11:42 AM
JArguello-WMF moved this task from Next Up to In Review on the Event-Platform (Sprint 14 B) board.
JArguello-WMF updated the task description. (Show Details)Jun 6 2023, 1:13 PM
JArguello-WMF moved this task from In Review to Done on the Event-Platform (Sprint 14 B) board.
JArguello-WMF closed this task as Resolved.Jun 20 2023, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits