Page MenuHomePhabricator
Create Task
Maniphest T329740

PHP Notice: Undefined property: stdClass::$href
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined property: stdClass::$href
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSectionsState.php(177)
#0 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSectionsState.php(177): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSectionsState.php(313): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSectionsState->computeSectionMetadata(Wikimedia\Parsoid\Core\SectionMetadata, Wikimedia\Parsoid\DOM\Element, integer)
#2 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSectionsState.php(418): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSectionsState->createNewSection(Wikimedia\Parsoid\DOM\Element, array, Wikimedia\Parsoid\Wt2Html\PP\Processors\Section, Wikimedia\Parsoid\DOM\Element, integer, boolean)
#3 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSectionsState.php(781): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSectionsState->wrapSectionsInDOM(Wikimedia\Parsoid\Wt2Html\PP\Processors\Section, Wikimedia\Parsoid\DOM\Element)
#4 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(31): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSectionsState->run()
#5 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(157): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections->run(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\DOM\Element, array, boolean)
#6 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(868): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(Wikimedia\Parsoid\DOM\Element, array, boolean)
#7 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(909): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(Wikimedia\Parsoid\DOM\Element)
#8 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(927): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(Wikimedia\Parsoid\DOM\Element)
#9 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(180): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#10 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(299): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#11 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(124): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#12 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Parsoid.php(174): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI)
#13 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/src/Parsoid.php(216): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, Wikimedia\Parsoid\Config\StubMetadataCollector, array)
#14 /srv/mediawiki/php-1.40.0-wmf.23/includes/parser/Parsoid/ParsoidOutputAccess.php(298): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#15 /srv/mediawiki/php-1.40.0-wmf.23/includes/parser/Parsoid/ParsoidOutputAccess.php(463): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parseInternal(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#16 /srv/mediawiki/php-1.40.0-wmf.23/includes/parser/Parsoid/ParsoidOutputAccess.php(244): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parse(MediaWiki\Page\PageStoreRecord, ParserOptions, array, MediaWiki\Revision\RevisionStoreRecord)
#17 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(689): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#18 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(519): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutputInternal(ParserOptions)
#19 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(612): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutput()
#20 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Handler/ParsoidHandler.php(870): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getPageBundle()
#21 /srv/mediawiki/php-1.40.0-wmf.23/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(92): MediaWiki\Rest\Handler\ParsoidHandler->wt2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#22 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Router.php(515): MWParsoid\Rest\Handler\PageHandler->execute()
#23 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/Router.php(421): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#24 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#25 /srv/mediawiki/php-1.40.0-wmf.23/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#26 /srv/mediawiki/php-1.40.0-wmf.23/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#27 /srv/mediawiki/w/rest.php(3): require(string)
#28 {main}
Impact
Notes
  • 600+ in the last hour, seems to all be on mediawikiwiki

Details

Request URL
https://www.mediawiki.org/w/rest.php/www.mediawiki.org/v3/page/pagebundle/Template%3ABlueSpiceExtension%2Fhu/4134567
SubjectRepoBranchLines +/-
Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0mediawiki/vendormaster+357 -205
Re-enable TOC datamediawiki/services/parsoidmaster+0 -5
Deal with parser functions generating headingsmediawiki/services/parsoidmaster+63 -3
Bump wikimedia/parsoid to 0.17.0-a16mediawiki/vendorwmf/1.40.0-wmf.23+25 -20
Bump wikimedia/parsoid to 0.17.0-a16mediawiki/vendormaster+25 -20
Temporarily suppress TOC datamediawiki/services/parsoidmaster+5 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedRelease• dduvallT325586 1.40.0-wmf.23 deployment blockers
 ResolvedPRODUCTION ERRORssastryT329740 PHP Notice: Undefined property: stdClass::$href

Event Timeline

TheresNoTime created this task.Feb 15 2023, 2:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2023, 2:14 PM
gerritbot added a comment.Feb 15 2023, 2:43 PM

Change 889551 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Deal with parser functions generating headings

https://gerrit.wikimedia.org/r/889551

gerritbot added a project: Patch-For-Review.Feb 15 2023, 2:43 PM
ssastry added subscribers: cscott, ssastry.Feb 15 2023, 2:46 PM

This is new (but unused by anything) functionality. This notice doesn't cause any user facing errors anywhere. So, I recommend suppressing this error in the log to eliminate noise during deployment.

But, I'll check with @cscott if we want to do a new parsoid release, etc.

ssastry added a comment.EditedFeb 15 2023, 3:32 PM

You will also see: PHP Notice: Trying to get property 'template' of non-object and PHP Notice: Undefined property: stdClass::$parts and PHP Notice: Trying to access array offset on value of type null -- all stemming from the same 4 lines of code as the one above.

The patch above fixes all of these notices, but we just need to decide if we want to wait till next week to deploy this OR release parsoid, vendor, etc ... we haven't done this before.

cscott added a comment.Feb 15 2023, 3:40 PM

As a quick-and-dirty backport fix we could also just comment out the call to ::computeSectionMetadata() too, couldn't we? That information isn't used by anything yet. That would give us more time to do a proper fix incl test case for the next train.

We'd still need to make that one-line change on a branch, tag a new parsoid, and backport it to mediawiki-vendor. Up to ops whether they feel that's worth doing -vs- just suppressing the three log messages for one week.

ssastry added a comment.Feb 15 2023, 3:50 PM

NOT: /srv/parsoid-testing/src/Wt2Html/PP/Processors/WrapSectionsState.php:177 and NOT: /srv/parsoid-testing/src/Wt2Html/PP/Processors/WrapSectionsState.php:171 will filter out all the logs from the broken code afact. So, that is the simplest option to narrowly filter out only errors form this patch and have this fixed next train.

Zabe triaged this task as Unbreak Now! priority.Feb 15 2023, 7:25 PM
Zabe added a parent task: T325586: 1.40.0-wmf.23 deployment blockers.
ssastry mentioned this in T325586: 1.40.0-wmf.23 deployment blockers.Feb 15 2023, 8:42 PM
gerritbot added a comment.Feb 15 2023, 9:02 PM

Change 889637 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Temporarily suppress TOC data

https://gerrit.wikimedia.org/r/889637

gerritbot added a comment.Feb 15 2023, 9:25 PM

Change 889637 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Temporarily suppress TOC data

https://gerrit.wikimedia.org/r/889637

Zabe subscribed.Feb 15 2023, 9:30 PM
gerritbot added a comment.Feb 15 2023, 10:12 PM

Change 889641 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a16

https://gerrit.wikimedia.org/r/889641

gerritbot added a comment.Feb 15 2023, 10:34 PM

Change 889641 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a16

https://gerrit.wikimedia.org/r/889641

gerritbot added a comment.Feb 15 2023, 10:36 PM

Change 889607 had a related patch set uploaded (by C. Scott Ananian; author: Subramanya Sastry):

[mediawiki/vendor@wmf/1.40.0-wmf.23] Bump wikimedia/parsoid to 0.17.0-a16

https://gerrit.wikimedia.org/r/889607

gerritbot added a comment.Feb 15 2023, 10:55 PM

Change 889607 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.40.0-wmf.23] Bump wikimedia/parsoid to 0.17.0-a16

https://gerrit.wikimedia.org/r/889607

Stashbot added a comment.Feb 15 2023, 10:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T22:55:50Z] <dduvall@deploy1002> Started scap: Backport for [[gerrit:889607|Bump wikimedia/parsoid to 0.17.0-a16 (T329740)]]

Stashbot added a comment.Feb 15 2023, 10:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T22:57:42Z] <dduvall@deploy1002> cscott and dduvall: Backport for [[gerrit:889607|Bump wikimedia/parsoid to 0.17.0-a16 (T329740)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 15 2023, 11:00 PM
Stashbot added a comment.Feb 15 2023, 11:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T23:04:37Z] <dduvall@deploy1002> Finished scap: Backport for [[gerrit:889607|Bump wikimedia/parsoid to 0.17.0-a16 (T329740)]] (duration: 08m 47s)

Agusbou2015 subscribed.Feb 15 2023, 11:13 PM
ssastry closed this task as Resolved.Feb 16 2023, 12:08 AM
ssastry claimed this task.
gerritbot added a comment.Feb 23 2023, 7:00 PM

Change 891597 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Re-enable TOC data

https://gerrit.wikimedia.org/r/891597

gerritbot added a comment.Mar 9 2023, 11:15 PM

Change 889551 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Deal with parser functions generating headings

https://gerrit.wikimedia.org/r/889551

gerritbot added a comment.Mar 9 2023, 11:53 PM

Change 891597 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Re-enable TOC data

https://gerrit.wikimedia.org/r/891597

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 12:10 AM
gerritbot added a comment.Mar 10 2023, 6:23 PM

Change 896413 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

gerritbot added a project: Patch-For-Review.Mar 10 2023, 6:23 PM
gerritbot added a comment.Mar 10 2023, 6:56 PM

Change 896413 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL