Page MenuHomePhabricator

Wrong value displayed using token input type and display titles
Open, Needs TriagePublicBUG REPORT

Event Timeline

I will have a patch ready today.

Change 889950 had a related patch set uploaded (by Your1; author: Your1):

[mediawiki/extensions/PageForms@master] Fixes https://phabricator.wikimedia.org/T329928

https://gerrit.wikimedia.org/r/889950

Change 889950 abandoned by Your1:

[mediawiki/extensions/PageForms@master] Fixes https://phabricator.wikimedia.org/T329928

Reason:

https://gerrit.wikimedia.org/r/889950

Change 890002 had a related patch set uploaded (by Your1; author: Your1):

[mediawiki/extensions/PageForms@master] Fix for wrong values being displayed in the form field using tokens and display titles

https://gerrit.wikimedia.org/r/890002

So, after extensively testing with this fix I don't have this issue anymore on my branch. We did encounter a other issue, which is similar to T283161 and T132128.

Our scenario is that we have one category that has a lot of pages in it (around 10.000). Each page in that category has its own display title. Whenever we edit that for, the 'possible' values are limited to whatever $wgPageFormsMaxAutocompleteValues is set to. This is problematic, because whenever we search (through the autocomplete) on a value that's further away then the 1000 prefilled values in the form, it doesn't get resolved correctly.

I've already written a fix for this, but its written on the same change (https://gerrit.wikimedia.org/r/890002) above. Do you want me to submit another patch, or fix this issue in the same change?

Change 890002 had a related patch set uploaded (by Your1; author: Your1):

[mediawiki/extensions/PageForms@master] Fix for wrong values being displayed in form fields when using tokens and display titles. Also fixed a bug for larger autocomplete fields (higher than the allowed $wgPageFormsMaxAutocompleteValues var) which didn't save the value if it would be outside the maxautocompletevalues range. See more at T329928.

https://gerrit.wikimedia.org/r/890002

So, after extensively testing with this fix I don't have this issue anymore on my branch. We did encounter a other issue, which is similar to T283161 and T132128.

Our scenario is that we have one category that has a lot of pages in it (around 10.000). Each page in that category has its own display title. Whenever we edit that for, the 'possible' values are limited to whatever $wgPageFormsMaxAutocompleteValues is set to. This is problematic, because whenever we search (through the autocomplete) on a value that's further away then the 1000 prefilled values in the form, it doesn't get resolved correctly.

I've already written a fix for this, but its written on the same change (https://gerrit.wikimedia.org/r/890002) above. Do you want me to submit another patch, or fix this issue in the same change?

I've submitted this in the same patch, because things would be overcomplicated otherwise.

Change 890002 abandoned by Your1:

[mediawiki/extensions/PageForms@master] Fix for wrong values being displayed in form fields when using tokens and display titles. Also fixed a bug for larger autocomplete fields (higher than the allowed $wgPageFormsMaxAutocompleteValues var) which didn't save the value if it would be outside the maxautocompletevalues range. See more at T329928.

Reason:

https://gerrit.wikimedia.org/r/890002

YOUR1 removed YOUR1 as the assignee of this task.Mar 2 2023, 9:53 AM

Change 890002 restored by Your1:

[mediawiki/extensions/PageForms@master] Fix for wrong values being displayed in form fields when using tokens and display titles. Also fixed a bug for larger autocomplete fields (higher than the allowed $wgPageFormsMaxAutocompleteValues var) which didn't save the value if it would be outside the maxautocompletevalues range. See more at T329928.

https://gerrit.wikimedia.org/r/890002