Page MenuHomePhabricator
Create Task
Maniphest T330624

[ES-M1] Update `mediawiki-codesniffer` in EntitySchema extension
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The current mediawiki-codesniffer definitions for the EntitySchema extension are out of date and should be updated.

Acceptance Criteria:

  • mediawiki-codesniffer is updated to the latest version
  • Any code style violations that are found should be fixed

Details

SubjectRepoBranchLines +/-
Have phpcs require strict types in new codemediawiki/extensions/EntitySchemamaster+4 -0
Begin to make use of new PHPCS rules in new codemediawiki/extensions/EntitySchemamaster+8 -8
Enforce trailing commas in multi-line arraysmediawiki/extensions/EntitySchemamaster+66 -59
Update mediawiki PHPCS config to 41.0.0mediawiki/extensions/EntitySchemamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Feb 27 2023, 8:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2023, 8:22 AM
ItamarWMDE added a parent task: T330622: [EPIC] Ensure EntitySchema dependencies are up-to-date .Feb 27 2023, 8:34 AM
ItamarWMDE added a comment.Feb 28 2023, 2:38 PM

Prio notes

  • Impact areas: Analyzability
  • Does not affect end users / production
  • Affects development efforts
  • Does not affect onboarding efforts
  • Does not affect additional stakeholders
ItamarWMDE moved this task from [DOT] Prioritized Epics to [DOT] Prioritized on the wmde-wikidata-tech board.Feb 28 2023, 2:39 PM
ItamarWMDE added a project: Wikidata Dev Team.
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Feb 28 2023, 2:59 PM
karapayneWMDE moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Mar 1 2023, 10:34 AM
ItamarWMDE renamed this task from Update `mediawiki-codesniffer` in EntitySchema extension to [ES-M1] Update `mediawiki-codesniffer` in EntitySchema extension.Mar 2 2023, 8:06 AM
noarave set the point value for this task to 2.Mar 9 2023, 9:56 AM
noarave moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
noarave edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
ItamarWMDE moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Mar 10 2023, 9:03 AM
ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Mar 10 2023, 9:20 AM
Michael moved this task from Backlog to M1: technical preparation on the EntitySchema board.Mar 10 2023, 10:16 AM
Michael edited projects, added EntitySchema (M1: technical preparation); removed EntitySchema.
Michael claimed this task.Mar 10 2023, 2:12 PM
Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptMar 10 2023, 2:12 PM
gerritbot added a comment.Mar 10 2023, 2:14 PM

Change 896351 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Update mediawiki PHPCS config to 41.0.0

https://gerrit.wikimedia.org/r/896351

gerritbot added a project: Patch-For-Review.Mar 10 2023, 2:14 PM
gerritbot added a comment.Mar 10 2023, 2:54 PM

Change 896364 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Begin to make use of new PHPCS rules in new code

https://gerrit.wikimedia.org/r/896364

Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Mar 10 2023, 2:56 PM
gerritbot added a comment.Mar 13 2023, 10:02 AM

Change 896351 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Update mediawiki PHPCS config to 41.0.0

https://gerrit.wikimedia.org/r/896351

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 13 2023, 11:00 AM
gerritbot added a comment.Mar 13 2023, 5:49 PM

Change 897956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/897956

Lucas_Werkmeister_WMDE subscribed.Mar 13 2023, 5:49 PM
In T330624#8688872, @gerritbot wrote:

Change 897956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/897956

Not sure if that belongs in this task, WDYT? :)

Michael added a comment.Mar 14 2023, 11:29 AM
In T330624#8688875, @Lucas_Werkmeister_WMDE wrote:
In T330624#8688872, @gerritbot wrote:

Change 897956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/897956

Not sure if that belongs in this task, WDYT? :)

I think it fits 👍

Do we have a rule for enforcing declare( strict_types=1 ); that we could turn on/add?

gerritbot added a comment.Mar 14 2023, 11:39 AM

Change 897956 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/897956

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 14 2023, 12:01 PM
gerritbot added a comment.Mar 16 2023, 12:47 AM

Change 896364 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Begin to make use of new PHPCS rules in new code

https://gerrit.wikimedia.org/r/896364

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2023, 1:10 AM
gerritbot added a comment.Mar 16 2023, 10:10 AM

Change 900223 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Have phpcs require strict types in new code

https://gerrit.wikimedia.org/r/900223

gerritbot added a project: Patch-For-Review.Mar 16 2023, 10:10 AM
gerritbot added a comment.Mar 16 2023, 5:08 PM

Change 900223 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Have phpcs require strict types in new code

https://gerrit.wikimedia.org/r/900223

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2023, 5:10 PM
noarave moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Mar 20 2023, 1:21 PM
ItamarWMDE closed this task as Resolved.Mar 20 2023, 7:53 PM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.May 12 2023, 8:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits