Page MenuHomePhabricator
Create Task
Maniphest T330684

IP Masking: Temporary account IP reveal unchecked & still revealing the Show IP button
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • In preferences make sure you have Temporary account IP reveal unchecked
  • In Development, check Disable cache
  • Under my Admin account I went to Special:Block and did a sitewide block on Testuserone which also has Admin rights
  • I went to Special:Blocklist and unblock the Autoblock so it was just a regular block on Testuserone in Special:Blocklist
  • I log in as Testuserone and go to Special:Contributions and click on unblock
  • Now I go to View History and click on Show IP on any of the Temp accounts

What happens?:
When you click Show IP, it does nothing.

What should have happened instead?:
Show IP button should be visible if the Temporary account IP reveal is unchecked

Other information (browser name/version, screenshots, etc.):

OS: macOS 13.0
Browsers: Chrome 109
Environment: Local

You can see full directions with screenshots below. Just add in preferences to uncheck Temporary account IP reveal
https://phabricator.wikimedia.org/T329072#8634729

Details

SubjectRepoBranchLines +/-
Check for checkuser-temporary-account-enable option before showing SHOW IP buttonmediawiki/extensions/CheckUsermaster+14 -3
Customize query in gerrit

Related Objects

Event Timeline

GMikesell-WMF created this task.Feb 27 2023, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2023, 5:49 PM
GMikesell-WMF mentioned this in T329072: IP Masking: Admins that are blocked have the Show IP button still visible.Feb 27 2023, 5:57 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 26: The Bycocket Hat); removed Anti-Harassment (AHaT Sprint 25: The Tengai Hat).Feb 28 2023, 6:30 PM
• AGueyte claimed this task.Feb 28 2023, 8:39 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 26: The Bycocket Hat) board.
gerritbot added a comment.Mar 1 2023, 5:01 PM

Change 893511 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/CheckUser@master] Check for checkuser-temporary-account-enable option before showing SHOW IP button

https://gerrit.wikimedia.org/r/893511

gerritbot added a project: Patch-For-Review.Mar 1 2023, 5:01 PM
• AGueyte mentioned this in T325451: [Epic] Users with appropriate privileges can opt-in to viewing IP addresses.Mar 1 2023, 5:07 PM
• AGueyte set the point value for this task to 2.Mar 1 2023, 5:11 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 26: The Bycocket Hat) board.Mar 1 2023, 5:31 PM
Dreamy_Jazz added a project: CheckUser.Mar 2 2023, 1:24 AM
Dreamy_Jazz moved this task from General / Unsorted to Temporary account IP reveal on the CheckUser board.Mar 2 2023, 2:31 AM
Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 26: The Bycocket Hat) board.Mar 2 2023, 1:42 PM
gerritbot added a comment.Mar 2 2023, 2:18 PM

Change 893511 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Check for checkuser-temporary-account-enable option before showing SHOW IP button

https://gerrit.wikimedia.org/r/893511

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2023, 2:31 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 2 2023, 3:00 PM
GMikesell-WMF updated the task description. (Show Details)Mar 3 2023, 12:22 AM
GMikesell-WMF added a subscriber: Dreamy_Jazz.Mar 3 2023, 12:26 AM

You can now reveal the IP address from the Show IP button as seen in the screenshot below. I will now move this to Done. Thanks @AGueyte and @Dreamy_Jazz!

T330684_IPMasking_Testuserone_UnblockResult.png (860×3 px, 405 KB)

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 26: The Bycocket Hat) board.Mar 3 2023, 12:27 AM
• Niharika closed this task as Resolved.Mar 11 2023, 12:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL