Change 888069 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/CheckUser@master] Don't Show IP button to blocked Admins

https://gerrit.wikimedia.org/r/888069

Change 888069 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Don't Show IP button to blocked Admins

https://gerrit.wikimedia.org/r/888069

@AGueyte Looks like the patch removed the ShowIP when you are blocked. I did get a couple of possible different issues as seen in the screenshots below. If you wanted me to create a new ticket for that since the actual ticket is resolved, please let me know. Thanks!

OS: macOS 13.0
Browsers: Chrome 109 and FireFox 109
Environment: Local

The Good- When an Admin gets blocked, ShowIP does not show up anymore

Unblocking Yourself -Is it suitable as a blocked Admin, if I go to Special:Contributions, I can unblock myself?

ShowIP not revealing - After I unblock myself when that account is supposed to be blocked, ShowIP does show but now it does not reveal the IP addresses when you click on it.

Hi George, thanks for this.

After an admin unblocked itself, the admin cannot see the IP appearing from View History despite the button showing.

It seems the behavior is related to an active autoblock generated from the original block.
Once removing the autoblock against the Admin's IP, the admin can see the IP appearing when clicking on the Show IP Button from a View History page.

Even with the autoblock, the ex-blocked admin can see the IP address after clicking the Show IP button from Special:Log (etc).

Guidance from Product on how we want to operate in this specific scenario.
Available to demonstrate the situation if needed.

cc @Niharika @Tchanders

Thanks @GMikesell-WMF and @AGueyte!

Unblocking Yourself -Is it suitable as a blocked Admin, if I go to Special:Contributions, I can unblock myself?

There's an unblockself right, so it sounds like your admin has this right. Otherwise, they wouldn't be able to unblock themselves.

ShowIP not revealing - After I unblock myself when that account is supposed to be blocked, ShowIP does show but now it does not reveal the IP addresses when you click on it.

After an admin unblocked itself, the admin cannot see the IP appearing from View History despite the button showing.

Hmm, I couldn't reproduce either of these - the unblocked admin could see the buttons and access IP addresses, as expected (including ones that were definitely not cached because they hadn't been accessed before).

Re: autoblocks:

• unblocking the admin should remove their autoblock at the same time
• if there's still an autoblock against the unblocked admin's IP address, it's probably an autoblock from another user's block
• the admin may or may not be affected by the autoblock, depending on their rights and the parameters of the autoblock, but they should either (a) see the buttons and the buttons work, or (b) not see the buttons, and the API doesn't work.

Re: different behaviour on history pages and Special:Log - in general the behaviour should be consistent throughout, and in general if buttons are present, they should reveal IP addresses. Looking at the code, the check for showing the buttons and the check for returning API results is the same, so it looks like it should work as expected.

@GMikesell-WMF Would it be possible to try again as an unblocked admin? If it still doesn't work, could you post a screenshot of Special:BlockList and also the error in the network tab, something like this, so we can see what the error key is?

@Tchanders and @AGueyte I'm still getting the issue of being unable to reveal IP address when I unblock myself. I can demonstrate whenever you are available if needed.

Before starting this, I did an empty cache and a hard reboot.

OS: macOS 13.0
Browsers: Chrome 109
Environment: Local

Steps

• 1. Under my Admin account I went to Special:Block and did a sitewide block on Testuserone which also has Admin rights
• 2. I went to Special:Blocklist and unblock the Autoblock so it was just a regular block on Testuserone in Special:Blocklist
• 3. I log in as Testuserone and go to Special:Contributions and click on unblock
• 4. Now I got to View History and click on Show IP on the Temp account which was *Unregistered 25
• 5. It does nothing. I am unable to reveal the IP address.

1. Testuserone Rights

2. Blocked Testuserone- I then unblocked Autoblock #73, which left just the regular sitewide block for 10 minutes time span in Special:BlockList

3. Logged in as Testuserson- I now went to Contributions and selected unblock

4 & 5. Show IP button unable to reveal IP address- When I click on the Show IP button, under Console, I get this highlighted error. This is the case in View history, Watchlist and I'm sure with the others.

Thanks @GMikesell-WMF this is very helpful. I'm wondering if this is because the API response was cached in your browser (i.e. the user is still getting the response they got when blocked). Could you try checking this box in developer tools so that the cache is disabled for each new request?

@Tchanders I started a new tab and prior to logging in as an Admin about to start step 1, I disabled the cache and repeated the steps from above. I am still having the same error though. I wouldn't be surprised if this has to do something with my local configurations though since you can't repeat it. Maybe I can show you when you are free so you might be able to pinpoint why this is happening better? According to Inspect, every time I click on Show IP after unblocking Testuserone, looks like I get that 403 Forbidden status error.

I also tried it on FireFox 109 on macOS 13.0 and got the same error as seen in the 2nd screenshot.

CheckUser and core are up to date.

macOS 13.0 w/ Chrome 109

macOS 13.0 w/ FireFox 109

After going through the issue with @Tchanders earlier, we found out this issue was happening since Temporary account IP reveal was unchecked. I created T330684: IP Masking: Temporary account IP reveal unchecked & still revealing the Show IP button for this bug since it was still showing the Show IP button when it is unchecked. Since the original issue has been resolved, I will move this current ticket to Done. Thanks for all your help @AGueyte and @Tchanders !