Confirming the revision ID is well added to the Username link via Linker::revUserTools in DifferenceEngine::showDiffPage()

To test, be on Master and have the latest pull from Git/Gerrit.
Make an edit on an existing page while logged out
Go to the page "view history" tab, click on the date of the first history log line
Click on the "diff" link within the yellow rectangle.

The diff page appears with the temp account named created from your logged-out edit as shown in the screenshot in the ticket's description.
Open the console to inspect the link, and the "data-mw-revid=x" should appear within the <a> element.

Thanks @AGueyte, looks good to me.

I'm moving to stalled until T326415: Add (show IP) buttons next to temporary account user name links is merged, since it will be easier for QA to test after that.

@Tchanders and @AGueyte I came across an issue that was not one before. This is in regards to blocking an Admin as seen in https://phabricator.wikimedia.org/T327437#8586051. In Chrome 109, even though the account is blocked, I can still reveal the IP address. In Firefox though, it still stayed as not being able to reveal an IP from Show IP when an account is blocked.

Also same issue as in Safari, which T328754: IP reveal buttons not displaying on Safari has been created.

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

Firefox 109

Different temp accounts with different IPs- Good

2 Different IPs under the same temp account- Good

I haven't had a chance to test properly, but a couple of thoughts:

• Am I right in understanding that the buttons are shown even to a blocked user? If so we should file a task to correct that
• The API should error if the user is blocked; however, the results are cached locally for 24 hours, so would still be visible to a recently-blocked user who accessed then while unblocked (which I think is fine, since they've already seen them). I suspect this is responsible for the differences in the different browser tests here. What happens if the cache is disabled (via developer tools, network tab)?

@Tchanders @AGueyte For non-admin users being blocked or non-admin in general, Show IP does not show up at all. If you block an Admin and create a temp edit recently as I made one right now, Show IP still shows up but it does not reveal the IP when you click on it. This only occurs on the current date as seen in the screenshots. On the older dates that are not today, you are able to reveal the IP address. I will move this to Done since there is a ticket for {T328754: IP reveal buttons not displaying on Safari} already and I just created ticket {T329072: IP Masking: Admins that are blocked have the Show IP button still visible} for this one. Thanks!