IP Address Reveal on History page
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Niharika
	Jan 6 2023, 6:24 AM

Description

Motivation

See parent T325238: [Epic] IP Address Reveal for Privileged Users for details.

Proposed mockup

The revealed IP address would say "show IP" before reveal occurs.

Testing notes

This is best tested along with T326415: Add (show IP) buttons next to temporary account user name links, which adds the buttons.

It should be tested locally, since it requires $wgAutoCreateTempUser['enabled'] = true; (only available on Beta) and the CheckUser extension (not available on Beta). It can't be fully tested on PatchDemo, because it isn't possible to edit from different IP addresses there.

Steps to test:

Edit some article from at least one temporary account, using at least two different IP addresses for that account
Go to the article's history page
Clicking on the "Reveal IP" buttons should reveal the correct IP addresses for each edit. Specifically, it should reveal different IP addresses, even for the same temporary account name.

Details

	Subject	Repo	Branch	Lines +/-
	Linker: Pass revision ID through to user link	mediawiki/core	master	+13 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	Niharika	T325238 [Epic] IP Address Reveal for Privileged Users
Resolved	Tchanders	T326392 IP Address Reveal on History page

Event Timeline

Niharika created this task.Jan 6 2023, 6:24 AM

Tchanders mentioned this in T324603: The CheckUser extension should provide IP addresses of temporary account users, for IP Masking.Jan 6 2023, 12:51 PM

Tchanders mentioned this in T326414: Update Linker::userLink to allow identification of temporary account usernames and provide some context.Jan 6 2023, 2:51 PM

Change 878018 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Linker: Pass revision ID through to user link

https://gerrit.wikimedia.org/r/878018

gerritbot added a project: Patch-For-Review.Jan 10 2023, 1:44 PM

Tchanders attached a referenced file: F35881742: image.png. (Show Details)Jan 10 2023, 1:44 PM

Tchanders claimed this task.Jan 11 2023, 12:12 PM

Tchanders added a project: Anti-Harassment (AHaT Sprint 22: Asian Conical Hat).

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 12 2023, 2:42 PM

Niharika mentioned this in T326840: [Design] Positioning the "show IP" links.Jan 12 2023, 6:16 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat); removed Anti-Harassment (AHaT Sprint 22: Asian Conical Hat).Jan 17 2023, 6:06 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 1:58 PM

Tchanders moved this task from QA/Testing 🐞 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 2:15 PM

Change 878018 merged by jenkins-bot:

[mediawiki/core@master] Linker: Pass revision ID through to user link

https://gerrit.wikimedia.org/r/878018

Moving this to stalled for now, as it's difficult for QA to test until the patches underneath are merged. Thanks @AGueyte

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2023, 2:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 19 2023, 3:00 PM

Tchanders mentioned this in T327437: The CheckUser extension should provide IP addresses of a temporary account user, given a list of revision IDs.Jan 19 2023, 6:34 PM

Tchanders mentioned this in T326396: IP Address Reveal on RecentChanges page.Jan 19 2023, 7:09 PM

Tchanders mentioned this in T326395: IP Address Reveal on Watchlist page.

Tchanders mentioned this in T326397: IP Address Reveal on Diff page.Jan 19 2023, 7:12 PM

• AGueyte moved this task from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 24 2023, 2:24 PM

In T326392#8540382, @Tchanders wrote:

Moving this to stalled for now, as it's difficult for QA to test until the patches underneath are merged. Thanks @AGueyte

Stalling this again - sorry I should clarify that it's going to be easier to test this once T326415: Add (show IP) buttons next to temporary account user name links is merged, since that adds the reveal buttons.

Tchanders updated the task description. (Show Details)Jan 24 2023, 4:07 PM

Niharika moved this task from Inbox to Ready on the Temporary accounts board.Jan 25 2023, 6:59 PM

ARamirez_WMF set the point value for this task to 2.Jan 25 2023, 7:01 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat); removed Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat).Jan 31 2023, 4:50 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.

Tchanders moved this task from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 1 2023, 2:47 PM

@Tchanders There was one issue just like in T326395, regarding not having the option of Show IP, in Safari. Also I did not have an issue when Special:Preferences#mw-prefsection-rc was unchecked like T326395 did. Otherwise I validated that it displays both different IP addresses I used with the same temp account as seen in the screenshots.

Skins: Vector 2022, Vector 2010, Timeless. MonoBook, Minerva

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

Safari- No Show IP

T326392_IPMasking_Safari_NoShow.png (907×1 px, 290 KB)

2 IP addresses with the same temp acct

T326392_IPMasking_History.png (1×1 px, 345 KB)

Result

Safari- No Show IP

Thanks for finding this - filed as T328754: IP reveal buttons not displaying on Safari.

If that's the only problem, I'm happy to move this on if you are.

@Tchanders I'm also good with moving this to Done since we have a ticket for T328754: IP reveal buttons not displaying on Safari. Thanks!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 6 2023, 6:29 PM

Dreamy_Jazz mentioned this in T331002: "Show IP" link not shown on Special:History or Special:MobileDiff when using MinervaNeue skin.Mar 2 2023, 12:43 PM

Tchanders closed this task as Resolved.Mar 3 2023, 5:30 PM

Stang unsubscribed.Mar 6 2023, 10:33 PM

	F36686510: T326392_IPMasking_History_Result.png
	Feb 2 2023, 8:00 PM

	F36687652: T326392_IPMasking_Safari_NoShow.png
	Feb 2 2023, 8:00 PM

IP Address Reveal on History pageClosed, ResolvedPublic2 Estimated Story PointsActions