Page MenuHomePhabricator

IP Address Reveal on Watchlist page
Closed, ResolvedPublic5 Estimated Story Points

Description

Motivation

See parent T325238: [Epic] IP Address Reveal for Privileged Users for details.

Proposed mockup

image.png (98×2 px, 79 KB)

There will be a "show IP" button next to the temp username (somewhere close to where the "talk" link is presumably). The button will expand in line to show the IP address instead.

What needs doing

T326415: Add (show IP) buttons next to temporary account user name links adds buttons next to temporary account name links, everywhere (including on Special:Watchlist):

  • By default these buttons fetch the last IP used by the temporary account
  • When the revision ID is present in the user link, it gets the IP associated with that revision ID

This task is for ensuring that the revision IDs are present in the user links displayed on Special:Watchlist.

There is an equivalent task that does the same for the history pages: T326392: IP Address Reveal on History page. The patch attached to that may have solved more cases than just the history page, so it is possible that it has solved this task too.

So what exactly needs doing?

  • Check whether revision IDs are present in the user links displayed on Special:Watchlist
  • If so, add a comment and close this task!
  • If not, add them. You'll need to find where the links are built, and pass through the data, like in T326392

How can I test this?

Event Timeline

Niharika set the point value for this task to 5.Jan 17 2023, 6:42 PM

Change 877246 had a related patch set uploaded (by STran; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add buttons for showing IP addresses next to temporary account user links

https://gerrit.wikimedia.org/r/877246

Change 884136 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

Change 884946 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

Change 884136 merged by jenkins-bot:

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

Change 884946 merged by jenkins-bot:

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

@Tchanders Here's a possible issue that I came across so far when you switch it to the old mode in change list. When I uncheck Special:Preferences#mw-prefsection-rc and created two edits with the same temp user with 2 different IPs, it does not show the other IP address I used. When I do have a check though, it reveals the 2 different IPs I used for that temp account. Also it does not show in Safari as seen in the last screenshot.

Skins: Vector 2022, Vector 2010, Timeless. MonoBook, Minerva

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

Special:Preferences#mw-prefsection-rc

T326395_IPMasking_Watchlist.png (191×1 px, 37 KB)

Supposed to have 2 different IP addresses just like the pic below
T326395_IPMasking_Watchlist_2IPs_NotChecked.png (795×1 px, 207 KB)

When checked, it shows the 2 different IP addresses I used
T326395_IPMasking_Watchlist_2IPs_Checked.png (1×1 px, 378 KB)

Revision ID and IP matches
T326395_IPMasking_Watchlist_Result.png (141×772 px, 25 KB)

Safari 16.0- No Show IP
T326395_IPMasking_Watchlist_Safari_NoShow.png (785×1 px, 276 KB)

Thanks @GMikesell-WMF - I've replied to the similar issues on the RecentChanges task: T326396#8584755 - will post here once we've got further with those.

Closing this, but leaving the Special:RecentChanges task open, pending answers to T326396#8584755