IP Address Reveal on Watchlist page
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Niharika
	Jan 6 2023, 6:46 AM

Description

Motivation

See parent T325238: [Epic] IP Address Reveal for Privileged Users for details.

Proposed mockup

There will be a "show IP" button next to the temp username (somewhere close to where the "talk" link is presumably). The button will expand in line to show the IP address instead.

What needs doing

T326415: Add (show IP) buttons next to temporary account user name links adds buttons next to temporary account name links, everywhere (including on Special:Watchlist):

By default these buttons fetch the last IP used by the temporary account
When the revision ID is present in the user link, it gets the IP associated with that revision ID

This task is for ensuring that the revision IDs are present in the user links displayed on Special:Watchlist.

There is an equivalent task that does the same for the history pages: T326392: IP Address Reveal on History page. The patch attached to that may have solved more cases than just the history page, so it is possible that it has solved this task too.

So what exactly needs doing?

Check whether revision IDs are present in the user links displayed on Special:Watchlist
If so, add a comment and close this task!
If not, add them. You'll need to find where the links are built, and pass through the data, like in T326392

How can I test this?

Check for the revision IDs in the HTML
You can test whether the buttons work using T326415: Add (show IP) buttons next to temporary account user name links
Note that there are two modes to test: T326396#8570913

Details

	Subject	Repo	Branch	Lines +/-
	EnhancedChangesList: Add latest revision ID to top level user link	mediawiki/core	master	+11 -8
	Add revision id to recent changes entry	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	Niharika	T340001 [Epic] Deployment plan
Open	Niharika	T348895 [Epic] Temporary accounts testwiki deployment
Open	Niharika	T325238 [Epic] IP Address Reveal for Privileged Users
Resolved	STran	T326395 IP Address Reveal on Watchlist page

Event Timeline

Niharika created this task.Jan 6 2023, 6:46 AM

Niharika mentioned this in T326840: [Design] Positioning the "show IP" links.Jan 12 2023, 6:16 PM

Niharika added a project: Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat).Jan 17 2023, 6:01 PM

Niharika set the point value for this task to 5.Jan 17 2023, 6:42 PM

STran claimed this task.Jan 19 2023, 11:27 AM

Change 877246 had a related patch set uploaded (by STran; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add buttons for showing IP addresses next to temporary account user links

https://gerrit.wikimedia.org/r/877246

gerritbot added a project: Patch-For-Review.Jan 19 2023, 11:28 AM

Work done for T326415: Add (show IP) buttons next to temporary account user name links covers this use case.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 11:29 AM

Tchanders updated the task description. (Show Details)Jan 19 2023, 7:11 PM

Tchanders moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 25 2023, 8:53 AM

Niharika moved this task from Backlog to Ready / In Progress (TSP) on the Temporary accounts board.Jan 25 2023, 6:59 PM

Change 884136 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 27 2023, 12:48 AM

Change 884946 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat); removed Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat).Jan 31 2023, 4:49 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.

Change 884136 merged by jenkins-bot:

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

Change 884946 merged by jenkins-bot:

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Jan 31 2023, 8:00 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 1 2023, 2:47 PM

Tchanders updated the task description. (Show Details)Feb 1 2023, 2:49 PM

@Tchanders Here's a possible issue that I came across so far when you switch it to the old mode in change list. When I uncheck Special:Preferences#mw-prefsection-rc and created two edits with the same temp user with 2 different IPs, it does not show the other IP address I used. When I do have a check though, it reveals the 2 different IPs I used for that temp account. Also it does not show in Safari as seen in the last screenshot.

Skins: Vector 2022, Vector 2010, Timeless. MonoBook, Minerva

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

Special:Preferences#mw-prefsection-rc

Supposed to have 2 different IP addresses just like the pic below

T326395_IPMasking_Watchlist_2IPs_NotChecked.png (795×1 px, 207 KB)

When checked, it shows the 2 different IP addresses I used

T326395_IPMasking_Watchlist_2IPs_Checked.png (1×1 px, 378 KB)

Revision ID and IP matches

Safari 16.0- No Show IP

T326395_IPMasking_Watchlist_Safari_NoShow.png (785×1 px, 276 KB)

GMikesell-WMF added a comment.Feb 2 2023, 6:31 PM

This comment was removed by GMikesell-WMF.

GMikesell-WMF mentioned this in T326392: IP Address Reveal on History page.Feb 2 2023, 8:00 PM

Thanks @GMikesell-WMF - I've replied to the similar issues on the RecentChanges task: T326396#8584755 - will post here once we've got further with those.

Tchanders moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 3 2023, 11:42 AM

@Tchanders Sounds good, thanks for your help!

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 7 2023, 2:39 PM

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 8 2023, 10:42 PM

Tchanders closed this task as Resolved.Mar 3 2023, 5:30 PM

Closing this, but leaving the Special:RecentChanges task open, pending answers to T326396#8584755

Stang unsubscribed.Mar 6 2023, 10:33 PM

	F36687503: T326395_IPMasking_Watchlist_Safari_NoShow.png
	Feb 2 2023, 7:27 PM

	F36686277: T326395_IPMasking_Watchlist_Result.png
	Feb 2 2023, 6:28 PM

	F36685993: T326395_IPMasking_Watchlist_2IPs_Checked.png
	Feb 2 2023, 6:28 PM

	F36685991: T326395_IPMasking_Watchlist_2IPs_NotChecked.png
	Feb 2 2023, 6:28 PM

	F36685989: T326395_IPMasking_Watchlist.png
	Feb 2 2023, 6:28 PM

IP Address Reveal on Watchlist pageClosed, ResolvedPublic5 Estimated Story PointsActions