Page MenuHomePhabricator
Create Task
Maniphest T369662

Expanded view of an item in Special:Watchlist when using advanced mode grouping has temporary account IPs as unavailable
Closed, ResolvedPublicBUG REPORT
Actions

Description

It seems that the temporary account IP reveal when using Special:Watchlist with "Group changes by page in recent changes and watchlist" checked in the preferences does not properly reveal the IP in the expanded view for a line.

Steps to replicate the issue
  1. Make at least two testing edits using a temporary account
  2. Log into an account with the checkuser group
  3. Go to Special:Preferences and navigate to the Recent changes section
  4. Check the Group changes by page in recent changes and watchlist preference
  5. Load Special:Watchlist and find the edits made in step 1
  6. Click on Show IP next to the temporary account username used in step 1
  7. Click on the arrow icon to expand the edits made by the temporary account

What happens?:
In the expanded list view, the IP address is shown as (unavailable). Before this patch it would be a mismatch to the IP shown in the shortened list above (because the expanded list would use the latest IP which was wrong).

Screenshot:

image.png (1×728 px, 254 KB)

What should have happened instead?:
The IP address should be correctly shown in the expanded view

Details

SubjectRepoBranchLines +/-
ipReveal.js: Fix revealing IP for grouped recent changes linesmediawiki/extensions/CheckUsermaster+178 -21
ipReveal.js: Fix bugs in multi-reveal functionalitymediawiki/extensions/CheckUsermaster+10 -5
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Jul 9 2024, 7:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2024, 7:31 PM
Dreamy_Jazz added a project: Trust and Safety Product Team.Jul 9 2024, 7:32 PM
Tchanders added a project: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 10 2024, 3:39 PM
Tchanders subscribed.

@Dreamy_Jazz and I discussed this.

In the grouped line, the IP addresses fetched are the latest ones, because there is no associated revision/log ID with each user link. The expanded lines do have IDs, and should show the IP address associated with each ID. This behaviour was decided and implemented in T326395.

The bug here

The bug introduced by this patch is that:

  • Now only the first button on the page performs an API lookup
  • The first button on the page performs a lookup for the latest IP, since it has no associated ID
  • The subsequent buttons have IDs, and assume that the API results are for an ID-based lookup
  • This assumption is wrong, so they find nothing for their own ID in the API results, so they display unavailable

We should fix that in this task.

Other related questions

These won't be answered in this task, so are captured in other tasks:

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 15 2024, 10:59 AM
Tchanders moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders claimed this task.Jul 15 2024, 1:38 PM
Tchanders moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 15 2024, 5:47 PM

Change #1054381 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] ipReveal.js: Fix bugs in multi-reveal functionality

https://gerrit.wikimedia.org/r/1054381

gerritbot added a project: Patch-For-Review.Jul 15 2024, 5:47 PM
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 15 2024, 6:03 PM
gerritbot added a comment.Jul 18 2024, 6:53 AM

Change #1054381 abandoned by Tchanders:

[mediawiki/extensions/CheckUser@master] ipReveal.js: Fix bugs in multi-reveal functionality

Reason:

Abandoning in favour of I33caa4dcb545f6c9a41b779f3eb745a6b52402cb

https://gerrit.wikimedia.org/r/1054381

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2024, 7:30 AM
gerritbot added a comment.Jul 18 2024, 7:30 AM

Change #1054383 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP ipReveal.js: Fix revealing IP for grouped recent changes lines

https://gerrit.wikimedia.org/r/1054383

gerritbot added a project: Patch-For-Review.Jul 18 2024, 7:30 AM
Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Jul 22 2024, 10:26 AM
gerritbot added a comment.Jul 22 2024, 4:34 PM

Change #1054383 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipReveal.js: Fix revealing IP for grouped recent changes lines

https://gerrit.wikimedia.org/r/1054383

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 22 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 22 2024, 5:30 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 22 2024, 6:07 PM
Djackson-ctr subscribed.Jul 24 2024, 5:36 AM

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (829×1 px, 127 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 24 2024, 5:37 AM
kostajh closed this task as Resolved.Jul 24 2024, 7:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits