IP Address Reveal on RecentChanges page
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Niharika
	Jan 6 2023, 6:46 AM

Description

Motivation

See parent T325238: [Epic] IP Address Reveal for Privileged Users for details.

Proposed mockup

There will be a "show IP" button next to the temp username (somewhere close to where the "talk" link is presumably). The button will expand in line to show the IP address instead.

What needs doing

T326415: Add (show IP) buttons next to temporary account user name links adds buttons next to temporary account name links, everywhere (including on Special:RecentChanges):

By default these buttons fetch the last IP used by the temporary account
When the revision ID is present in the user link, it gets the IP associated with that revision ID

This task is for ensuring that the revision IDs are present in the user links displayed on Special:RecentChanges.

There is an equivalent task that does the same for the history pages: T326392: IP Address Reveal on History page. The patch attached to that may have solved more cases than just the history page, so it is possible that it has solved this task too.

So what exactly needs doing?

Check whether revision IDs are present in the user links displayed on Special:RecentChanges
If so, add a comment and close this task!
If not, add them. You'll need to find where the links are built, and pass through the data, like in T326392

How can I test this?

Check for the revision IDs in the HTML
You can test whether the buttons work using T326415: Add (show IP) buttons next to temporary account user name links
Note that there are two modes to test: T326396#8570913

Details

Subject	Repo	Branch	Lines +/-
Fix data-mw-revid attribute read on RecentChanges page for IPReveal	mediawiki/extensions/CheckUser	master	+16 -6
OldChangesList: Pass revision ID through to user link	mediawiki/core	master	+6 -2
EnhancedChangesList: Add latest revision ID to top level user link	mediawiki/core	master	+11 -8
Add revision id to recent changes entry	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	Niharika	T340001 [Epic] Deployment plan
Open	Niharika	T348895 [Epic] Temporary accounts testwiki deployment
Open	Niharika	T325238 [Epic] IP Address Reveal for Privileged Users
Resolved	STran	T326396 IP Address Reveal on RecentChanges page

Event Timeline

Niharika removed Niharika as the assignee of this task.Jan 6 2023, 6:46 AM

Niharika created this task.

Niharika removed a project: Epic.

Niharika mentioned this in T326840: [Design] Positioning the "show IP" links.Jan 12 2023, 6:16 PM

Niharika added a project: Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat).Jan 17 2023, 6:01 PM

Niharika set the point value for this task to 5.Jan 17 2023, 6:42 PM

STran claimed this task.Jan 18 2023, 7:17 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 10:20 AM

Tchanders attached a referenced file: F36004384: image.png. (Show Details)Jan 19 2023, 10:25 AM

Change 877246 had a related patch set uploaded (by STran; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add buttons for showing IP addresses next to temporary account user links

https://gerrit.wikimedia.org/r/877246

gerritbot added a project: Patch-For-Review.Jan 19 2023, 11:26 AM

Work done for T326415: Add (show IP) buttons next to temporary account user name links covers this use case.

STran moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 11:27 AM

In T326396#8539811, @STran wrote:

Work done for T326415: Add (show IP) buttons next to temporary account user name links covers this use case.

Most, but not all! I've added more to the task description, to explain.

Tchanders moved this task from Blocked/Stalled 🚧 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 19 2023, 7:10 PM

Niharika moved this task from Backlog to Ready / In Progress (TSP) on the Temporary accounts board.Jan 25 2023, 6:59 PM

Change 884136 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 27 2023, 12:23 AM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 27 2023, 12:48 AM

@Niharika I did some minimal work to get Thalia's patch to work on Special:RecentChanges and noticed this was a side effect. Is this okay? Or should we aim for a different UX?

I edited from 2 IPs and that's why "*Unregistered 7 " looks like a duplicate.

Change 884946 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

In T326396#8563617, @STran wrote:

@Niharika I did some minimal work to get Thalia's patch to work on Special:RecentChanges and noticed this was a side effect. Is this okay? Or should we aim for a different UX?

I edited from 2 IPs and that's why "*Unregistered 7 " looks like a duplicate.

I'll answer in @Niharika's absence! I think we should avoid the repetition, since it could make the top-level line quite busy. I think the repetition is potentially confusing for anyone who can't reveal IPs, or when looking at non-temp users, since all we would show in those situations are repeated user names.

Have added a small patch on top to display only the most recent revision's IP in the top-level line.

We could move ahead with this, and ask Niharika to review on her return?

Change 884966 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] OldChangesList: Pass revision ID through to user link

https://gerrit.wikimedia.org/r/884966

While reviewing I spotted another place that needs updating. There's an old mode for changes lists, which can be tested by unchecking this box in Special:Preferences#mw-prefsection-rc :

Should be fixed by the above patch.

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat); removed Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat).Jan 31 2023, 4:49 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.

Change 884136 merged by jenkins-bot:

[mediawiki/core@master] Add revision id to recent changes entry

https://gerrit.wikimedia.org/r/884136

Change 884946 merged by jenkins-bot:

[mediawiki/core@master] EnhancedChangesList: Add latest revision ID to top level user link

https://gerrit.wikimedia.org/r/884946

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Jan 31 2023, 8:00 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 1 2023, 2:47 PM

Tchanders updated the task description. (Show Details)

Tchanders mentioned this in T326395: IP Address Reveal on Watchlist page.Feb 1 2023, 2:49 PM

@Tchanders Descriptions of the errors I came across are associated with the screenshots below

Skins: Vector 2022, Vector 2010, Timeless. MonoBook, Minerva

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

When I uncheck Special:Preferences#mw-prefsection-rc, it didn't catch the different IP (103.130.145.255) I used with the same temp user.

T326396_IPMasking_RecentChanges_2IPs_NotChecked.png (1×2 px, 564 KB)

Skin: Minerva- It didn't catch the different IP (103.130.145.255) I used with the same temp user.

T326396_IPMasking_RecentChanges_Minerva_WrongIP.png (1×1 px, 194 KB)

Safai 16.0- Didn't have the option of "Show IP"

T326396_IPMasking_RecentChanges_Safari_NoShow.png (770×1 px, 272 KB)

Possible Issue: I'm not sure if this is by design but as you see I have 2 different IP addresses for the same temp user that is pointed by the arrows. In the main header highlighted it showed one of the IP addresses I used and "2x". Is it supposed to show the other IP address used, which is "103.130.145.255" along with "2001:240:0:0:0:0:0:0"?

T326396_IPMasking_RecentChanges_OneIPHeader_.png (871×2 px, 309 KB)

Tchanders mentioned this in T328750: Display IP reveal buttons on Special:RecentChanges and Special:WatchList in Minerva.Feb 3 2023, 11:26 AM

In T326396#8584101, @GMikesell-WMF wrote:

@Tchanders Descriptions of the errors I came across are associated with the screenshots below

Skins: Vector 2022, Vector 2010, Timeless. MonoBook, Minerva

OS: macOS 13.0
Browsers: Chrome 109, Safari 16, FireFox 109
Environment: Local

When I uncheck Special:Preferences#mw-prefsection-rc, it didn't catch the different IP (103.130.145.255) I used with the same temp user.

Ah, it looks like the patch for this hasn't been merged. @STran could you review it? It's tagged against this task further up - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/884966/

Skin: Minerva- It didn't catch the different IP (103.130.145.255) I used with the same temp user.

It looks like this whole page is working differently in Minerva. Here's a separate task for that: T328750: Display IP reveal buttons on Special:RecentChanges and Special:WatchList in Minerva

Safai 16.0- Didn't have the option of "Show IP"

This seems odd. ~~Do the buttons show up in Safari on any other pages?~~ Apparently this is happening in other places (e.g. T326392#8583299).

Filed as T328754: IP reveal buttons not displaying on Safari.

Possible Issue: I'm not sure if this is by design but as you see I have 2 different IP addresses for the same temp user that is pointed by the arrows. In the main header highlighted it showed one of the IP addresses I used and "2x". Is it supposed to show the other IP address used, which is "103.130.145.255" along with "2001:240:0:0:0:0:0:0"?

We decided to do this for now, but it should be reviewed by @Niharika - what would you like to do here? If something different, we should file that as a new task.

Tchanders moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 3 2023, 11:42 AM

Change 884966 merged by jenkins-bot:

[mediawiki/core@master] OldChangesList: Pass revision ID through to user link

https://gerrit.wikimedia.org/r/884966

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 7 2023, 11:00 AM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 7 2023, 2:39 PM

@Tchanders @AGueyte Please see below.

When I uncheck Special:Preferences#mw-prefsection-rc, it didn't catch the different IP (103.130.145.255) I used with the same temp user.

It now shows the two different IP addresses as seen in the screenshots after the patch.

Possible Issue: I'm not sure if this is by design but as you see I have 2 different IP addresses for the same temp user that is pointed by the arrows. In the main header highlighted it showed one of the IP addresses I used and "2x". Is it supposed to show the other IP address used, which is "103.130.145.255" along with "2001:240:0:0:0:0:0:0"?

We decided to do this for now, but it should be reviewed by @Niharika - what would you like to do here? If something different, we should file that as a new task.

Did you want me to create a separate ticket for this @Niharika or will this be as designed for now? Otherwise, I will move this to Done since the other issues have tickets already. Thanks!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 24: The Toque Blanche Hat) board.Feb 8 2023, 6:30 PM

SCP-2000 unsubscribed.Feb 9 2023, 4:06 AM

In T326396#8599004, @GMikesell-WMF wrote:

Possible Issue: I'm not sure if this is by design but as you see I have 2 different IP addresses for the same temp user that is pointed by the arrows. In the main header highlighted it showed one of the IP addresses I used and "2x". Is it supposed to show the other IP address used, which is "103.130.145.255" along with "2001:240:0:0:0:0:0:0"?

We decided to do this for now, but it should be reviewed by @Niharika - what would you like to do here? If something different, we should file that as a new task.

Did you want me to create a separate ticket for this @Niharika or will this be as designed for now? Otherwise, I will move this to Done since the other issues have tickets already. Thanks!

@GMikesell-WMF sorry for the late reply -- could you file a bug please? I think the right behavior will be to say something like "103.130.145.255 and 1 more". I will need to run this by Rita/Prateek.
I'll go ahead and close this task. Follow up can be in the new task.

Niharika closed this task as Resolved.Mar 4 2023, 8:25 PM

@GMikesell-WMF sorry for the late reply -- could you file a bug please? I think the right behavior will be to say something like "103.130.145.255 and 1 more". I will need to run this by Rita/Prateek.
I'll go ahead and close this task. Follow up can be in the new task.

@Niharika I created T331369: IP Masking: 2 different IP for same temp user in Recent Changes Group"2x", thanks!

GMikesell-WMF mentioned this in T331369: IP Masking: 2 different IP for same temp user in Recent Changes Group"2x".Mar 6 2023, 11:43 PM

Stang unsubscribed.Mar 10 2023, 10:33 PM

Change 940177 had a related patch set uploaded (by Ttomalak; author: Ttomalak):

[mediawiki/extensions/CheckUser@master] Fix revId fetching on RecentChange page for IPReveal

https://gerrit.wikimedia.org/r/940177

Change 940177 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix data-mw-revid attribute read on RecentChanges page for IPReveal