Page MenuHomePhabricator
Create Task
Maniphest T330951

Allow maintenance/Generate.php to be run without a LocalSetting
Closed, ResolvedPublic
Actions

Description

Would it be possible to patch the rETXF maintenance/Generate.php script to use the feature coded in rMW7dcfbf2a6263: Allow some maintenance scripts to be called without a LocalSettings?

This script converts the data from rETXF trusted-hosts.txt to PHP and JSON format.

I tried to upload a patch today to update the list of trusted proxies but was unable to populate the rETXF trusted-hosts.php and rETXF trusted-hosts.json files with the updated data from rETXF trusted-hosts.txt. AFAICS the script seems to expect not only a MW_INSTALL_PATH but actually a MediaWiki installation.

Considering the script purpose, it would would be useful to allow to run it standalone for proxy data updates.

Thank you

Details

SubjectRepoBranchLines +/-
generate.php: Remove requireExtension to run without LocalSettingsmediawiki/extensions/TrustedXFFmaster+2 -1
Generate: Allow script to run without LocalSettingsmediawiki/extensions/TrustedXFFmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Mar 1 2023, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2023, 10:26 PM
gerritbot added a comment.Mar 1 2023, 10:44 PM

Change 893543 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TrustedXFF@master] Generate: Allow script to run without LocalSettings

https://gerrit.wikimedia.org/r/893543

gerritbot added a project: Patch-For-Review.Mar 1 2023, 10:44 PM
gerritbot added a comment.Apr 3 2023, 9:27 AM

Change 893543 merged by jenkins-bot:

[mediawiki/extensions/TrustedXFF@master] Generate: Allow script to run without LocalSettings

https://gerrit.wikimedia.org/r/893543

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Apr 3 2023, 3:02 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2023, 3:10 PM
gerritbot added a comment.Dec 19 2023, 7:47 PM

Change 984267 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TrustedXFF@master] generate.php: Remove requireExtension to run without LocalSettings

https://gerrit.wikimedia.org/r/984267

gerritbot added a project: Patch-For-Review.Dec 19 2023, 7:47 PM
gerritbot added a comment.Dec 23 2023, 8:10 AM

Change 984267 merged by jenkins-bot:

[mediawiki/extensions/TrustedXFF@master] generate.php: Remove requireExtension to run without LocalSettings

https://gerrit.wikimedia.org/r/984267

Umherirrender closed this task as Resolved.Dec 23 2023, 8:24 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 23 2023, 8:29 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 23 2023, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL