Page MenuHomePhabricator
Create Task
Maniphest T331084

TypeError: Argument 2 passed to Wikimedia\Parsoid\Config\StubMetadataCollector::collect() must be of the type string, int given,
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to Wikimedia\Parsoid\Config\StubMetadataCollector::collect() must be of the type string, int given, called in /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Config/StubMetadataCollect
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Config/StubMetadataCollector.php(140)
#0 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Config/StubMetadataCollector.php(57): Wikimedia\Parsoid\Config\StubMetadataCollector->collect(string, integer, string, string)
#1 /srv/mediawiki/php-1.40.0-wmf.25/includes/parser/ParserOutput.php(2291): Wikimedia\Parsoid\Config\StubMetadataCollector->addCategory(integer, string)
#2 /srv/mediawiki/php-1.40.0-wmf.25/includes/parser/Parsoid/Config/DataAccess.php(369): ParserOutput->collectMetadata(Wikimedia\Parsoid\Config\StubMetadataCollector)
#3 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(138): MediaWiki\Parser\Parsoid\Config\DataAccess->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, Wikimedia\Parsoid\Config\StubMetadataCollector, string)
#4 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(279): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onExtension(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#5 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(150): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#6 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(132): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#7 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(195): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#8 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(193): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#9 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/TreeBuilder/TreeBuilderStage.php(497): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#10 [internal function]: Wikimedia\Parsoid\Wt2Html\TreeBuilder\TreeBuilderStage->processChunkily(string, array)
#11 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(923): Generator->current()
#12 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(180): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#13 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(299): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#14 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(124): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#15 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Parsoid.php(174): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI)
#16 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/src/Parsoid.php(216): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, Wikimedia\Parsoid\Config\StubMetadataCollector, array)
#17 /srv/mediawiki/php-1.40.0-wmf.25/includes/parser/Parsoid/ParsoidOutputAccess.php(298): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#18 /srv/mediawiki/php-1.40.0-wmf.25/includes/parser/Parsoid/ParsoidOutputAccess.php(463): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parseInternal(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#19 /srv/mediawiki/php-1.40.0-wmf.25/includes/parser/Parsoid/ParsoidOutputAccess.php(244): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parse(MediaWiki\Page\PageStoreRecord, ParserOptions, array, MediaWiki\Revision\RevisionStoreRecord)
#20 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(689): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#21 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(519): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutputInternal(ParserOptions)
#22 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(612): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutput()
#23 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Handler/ParsoidHandler.php(870): MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getPageBundle()
#24 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(92): MediaWiki\Rest\Handler\ParsoidHandler->wt2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#25 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Router.php(515): MWParsoid\Rest\Handler\PageHandler->execute()
#26 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/Router.php(421): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#27 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#28 /srv/mediawiki/php-1.40.0-wmf.25/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#29 /srv/mediawiki/php-1.40.0-wmf.25/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#30 /srv/mediawiki/w/rest.php(3): require(string)
#31 {main}
Impact
Notes

Details

Request URL
https://fr.wikisource.org/w/rest.php/fr.wikisource.org/v3/page/pagebundle/Le_Retour_de_l%E2%80%99Empereur/9019673
SubjectRepoBranchLines +/-
parsoid: use real ParserOutput, not StubMetadataCollector in wikitext2lintmediawiki/coremaster+6 -2
Preserve non-PageBundle metadata set by Parsoidmediawiki/coremaster+87 -6
Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0mediawiki/vendormaster+357 -205
Ensure categories are returned as stringsmediawiki/coremaster+11 -5
StubMetadataCollector: handle numeric string category names correctlymediawiki/services/parsoidmaster+2 -1
Customize query in gerrit

Event Timeline

ssastry created this task.Mar 3 2023, 4:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2023, 4:47 AM
cscott moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 9 2023, 3:29 PM
cscott claimed this task.Mar 9 2023, 3:38 PM
cscott subscribed.

I'm looking at this.

gerritbot added a comment.Mar 9 2023, 4:04 PM

Change 896123 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Preserve non-PageBundle metadata set by Parsoid

https://gerrit.wikimedia.org/r/896123

gerritbot added a project: Patch-For-Review.Mar 9 2023, 4:04 PM
gerritbot added a comment.Mar 9 2023, 4:17 PM

Change 896127 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Ensure categories are returned as strings

https://gerrit.wikimedia.org/r/896127

thcipriani moved this task from Untriaged to Mar 2023 on the Wikimedia-production-error board.Mar 9 2023, 4:52 PM
gerritbot added a comment.Mar 9 2023, 5:18 PM

Change 896140 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] StubMetadataCollector: handle numeric string category names correctly

https://gerrit.wikimedia.org/r/896140

gerritbot added a comment.Mar 9 2023, 5:36 PM

Change 896140 merged by jenkins-bot:

[mediawiki/services/parsoid@master] StubMetadataCollector: handle numeric string category names correctly

https://gerrit.wikimedia.org/r/896140

gerritbot added a comment.Mar 10 2023, 4:55 PM

Change 896127 merged by jenkins-bot:

[mediawiki/core@master] Ensure categories are returned as strings

https://gerrit.wikimedia.org/r/896127

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 5:00 PM
gerritbot added a comment.Mar 10 2023, 6:23 PM

Change 896413 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

gerritbot added a comment.Mar 10 2023, 6:56 PM

Change 896413 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

gerritbot added a comment.Mar 13 2023, 5:14 PM

Change 896123 merged by jenkins-bot:

[mediawiki/core@master] Preserve non-PageBundle metadata set by Parsoid

https://gerrit.wikimedia.org/r/896123

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2023, 5:30 PM
cscott closed this task as Resolved.Mar 16 2023, 2:24 PM

Should be fixed.

gerritbot added a comment.Sep 20 2024, 3:03 PM

Change #1074448 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] parsoid: use real ParserOutput, not StubMetadataCollector in wikitext2lint

https://gerrit.wikimedia.org/r/1074448

gerritbot added a project: Patch-For-Review.Sep 20 2024, 3:03 PM
gerritbot added a comment.Sep 24 2024, 5:50 PM

Change #1074448 merged by jenkins-bot:

[mediawiki/core@master] parsoid: use real ParserOutput, not StubMetadataCollector in wikitext2lint

https://gerrit.wikimedia.org/r/1074448

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 24 2024, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2024, 6:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits