Page MenuHomePhabricator

Search through reviews a user has done at copypatrol
Closed, ResolvedPublic3 Estimated Story PointsFeature

Description

Per discussion between me and MusikAnimal at https://meta.wikimedia.org/wiki/Talk:CopyPatrol#Diannaa_stepping_back,_new_features , I think it'd be nice to have a feature at Copypatrol that allows you to look through all the reviews someone has done.

Acceptance criteria

  • When "Reviewed cases" is selected, there should be a "Search reviews by user" field.
  • After submitting with the username of someone who has done reviews (such myself, MusikAnimal), you should see only reviews by said user.
  • On the "Leaderboard" page, the counts of each user's reviews should link to the feed with only reviews by said user (note the feed is not limited to a specific timeframe however, but the Leaderboard counts are)

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald Transcript
Aklapper changed the subtype of this task from "Task" to "Feature Request".Mar 5 2023, 10:26 AM

@Money_emoji: Thanks for reporting this. For future reference, please use the feature request form (linked from the top of the task creation page) to create feature requests, and fill in the sections in the template. Thanks.

Noting here that a PR for this change was submitted on GitHub (here) last March 5.

Related PR has been merged, now just have to wait for the changes to be applied on Toolforge. ๐Ÿ‘

PR merged and deployed! This could benefit from QA, but I'm going to leave it to our QA engineers to decide whether it's worth their time, as I assume they're unfamiliar with CopyPatrol. The acceptance criteria hopefully details all you need to know. Please ping me if you'd like a general walk-through of CopyPatrol, or if you have any other questions! The tool is at https://copypatrol.toolforge.org and we also have user documentation.

@MusikAnimal I have a couple of very minor ones. Otherwise, the "Search reviews by user:" does pop up when you select the radio button of "Reviewed cases" and only shows the "Reviewed by:" from the user you have entered. Also same goes for the Leaderboard when clicking on the number, goes to the "Reviewed by:" (except at 400% zoom: see below). Also wanted to make sure on the Leaderboard, it's just supposed to link to the reviewed by and not also the actual number that's on the Leaderboard, right? (ex. Star Mississippi: 2, it's not going to only show 2 of them but all "Reviewed by:" under that user's name)

OS: macOS 13.2 & Windows 11
Browsers: Safari 16.3, Chrome, 111, Edge 111, Firefox 111
Test link: https://copypatrol.toolforge.org/en/

Zoom @ 400% - For some reason at only this percentage on some users, you lose the number link to click on.

T331219_CopyPatrol_Zoom_400.png (1ร—2 px, 279 KB)

Case Sensivity- I'm sure this is as designed but just making sure that when you enter the user's name, it has to be case-sensitive.

T331219_CopyPatrol_CaseSensitive.png (356ร—2 px, 79 KB)

Also wanted to make sure on the Leaderboard, it's just supposed to link to the reviewed by and not also the actual number that's on the Leaderboard, right? (ex. Star Mississippi: 2, it's not going to only show 2 of them but all "Reviewed by:" under that user's name)

Correct. The feed doesn't have options for the time frame like the Leaderboard does, so this is expected behaviour.

Zoom @ 400% - For some reason at only this percentage on some users, you lose the number link to click on.

T331219_CopyPatrol_Zoom_400.png (1ร—2 px, 279 KB)

Fixed!

Case Sensivity- I'm sure this is as designed but just making sure that when you enter the user's name, it has to be case-sensitive.

T331219_CopyPatrol_CaseSensitive.png (356ร—2 px, 79 KB)

Correct, usernames are case sensitive. This made me think we should probably add an autocomplete search.

@MusikAnimal The number links are now visible and are able to be clicked on but it went to the next line as seen in the screenshot.

T331219_CopyPatrol_Zoom_400_Alignment.png (1ร—2 px, 300 KB)

MusikAnimal set the point value for this task to 3.Mar 27 2023, 8:16 PM

@MusikAnimal The number links are now visible and are able to be clicked on but it went to the next line as seen in the screenshot.

As discussed on Slack, this is expected behaviour.

Sounds good, I will move this to Done. Thanks again!