Page MenuHomePhabricator

Special:preferences scrollbar in monobook
Closed, ResolvedPublicBUG REPORT

Description

In tech news was announced that searching in preferences is now avaliable. Now I have horizontal scrollbar in special:preferences page. When I make window bigger, scrollbar is still here. When I switch from monobook to vector, scrollbar disappear.

image.png (927×1 px, 122 KB)

Event Timeline

It's the negative margins on #preferences .mw-htmlform-submit-buttons in the Apex skin of ooui that seems to be causing this.

In tech news was announced that searching in preferences is now avaliable. Now I have horizontal scrollbar in special:preferences page.

That's entirely unrelated to each other, as your screenshot does not show any search...

In tech news was announced that searching in preferences is now avaliable. Now I have horizontal scrollbar in special:preferences page.

That's entirely unrelated to each other.

Well... not necessarily, it could have been related. But, considering that some people report this issue BEFORE they have the new deploy.. it's likely a 1.40.0-wmf25 issue from last week's changes.

[edit] I can reproduce it at https://en.wikipedia.org/wiki/Special:Preferences?useskin=monobook which is still on 25.

Change 896125 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] preferences: Use `em` instead of `px` to improve skin compatibility

https://gerrit.wikimedia.org/r/896125

Change 896125 merged by jenkins-bot:

[mediawiki/core@master] preferences: Use `em` instead of `px` to improve skin compatibility

https://gerrit.wikimedia.org/r/896125

The fix will be deployed to Wikimedia wikis this week per the usual schedule. Thanks for the bug report!