Page MenuHomePhabricator

🥸️ Handle aliases not found for item
Closed, ResolvedPublic

Description

  • if there is no alias for the given language, throw a UseCaseError with new errorCode ALIASES_NOT_DEFINED
  • generate a 404 response from the error
{
   "code": "aliases-not-defined",
   "message": "Item with the ID {item_id} does not have aliases in the language: {language_code}"
}

Event Timeline

Silvan_WMDE renamed this task from 🏷️ Handle label not found for item to 🥸️ Handle aliases not found for item.Mar 20 2023, 12:04 PM
Silvan_WMDE updated the task description. (Show Details)

Change 901548 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Handle aliases not found for an item

https://gerrit.wikimedia.org/r/901548

Change 901548 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Handle aliases not found for an item

Reason:

switching to a simpler solution

https://gerrit.wikimedia.org/r/901548

Change 901589 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Respond with 404 if no aliases found for specific lang

https://gerrit.wikimedia.org/r/901589

Change 901589 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Respond with 404 if no aliases found for specific lang

https://gerrit.wikimedia.org/r/901589

as smartly pointed out, the better error message would talk about plural aliases, given it is always a list. Apologies for additional work due to this mistake of mine. Adjusting the task description accordingly

Change 901919 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Change 'alias' to 'aliases'

https://gerrit.wikimedia.org/r/901919

Change 901919 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Change 'alias' to 'aliases'

https://gerrit.wikimedia.org/r/901919