Page MenuHomePhabricator

Multiple restbase servers have not received any deployments since at least October 2022
Closed, ResolvedPublic

Description

Change 803877 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop: Modify page denylist

https://gerrit.wikimedia.org/r/803877

A separate list was also removed from restbase configuration in T316914: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): Rerenders for this article are blacklisted in the config from DiscussionTools – permalinks unavailable for some pages / https://github.com/wikimedia/restbase/pull/1305.

Both of those commits removed the entry for '/Commons:Featured_picture_candidates\//' on commons, but: when I request https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AHalle_(Saale)_-_Landgericht_-_Treppenhaus_-_Decke_(2128).jpg?redirect=false with a 2.7.0 Accept header, I get a HTTP 403 with:

2023-03-25T20:15:07.107978Z DEBUG parsoid::api: req=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured%20picture%20candidates%2FFile%3AHalle%20%28Saale%29%20-%20Landgericht%20-%20Treppenhaus%20-%20Decke%20%282128%29.jpg", query: Some("redirect=false"), fragment: None }, headers: {"accept": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\""} }
2023-03-25T20:15:07.815847Z DEBUG parsoid::api: resp=Response { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AHalle_(Saale)_-_Landgericht_-_Treppenhaus_-_Decke_(2128).jpg", query: Some("redirect=false"), fragment: None }, status: 403, headers: {"access-control-allow-origin": "*", "access-control-allow-methods": "GET,HEAD", "access-control-allow-headers": "accept, content-type, content-length, cache-control, accept-language, api-user-agent, if-match, if-modified-since, if-none-match, dnt, accept-encoding", "access-control-expose-headers": "etag", "x-content-type-options": "nosniff", "x-frame-options": "SAMEORIGIN", "referrer-policy": "origin-when-cross-origin", "x-xss-protection": "1; mode=block", "content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-webkit-csp": "default-src 'none'; frame-ancestors 'none'", "content-location": "https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AHalle_(Saale)_-_Landgericht_-_Treppenhaus_-_Decke_(2128).jpg", "cache-control": "private, max-age=0, s-maxage=0, must-revalidate", "server": "restbase1033", "content-type": "application/problem+json", "content-length": "323", "date": "Sat, 25 Mar 2023 20:15:08 GMT", "age": "0", "x-cache": "cp1085 miss, cp1077 pass", "x-cache-status": "pass", "server-timing": "cache;desc=\"pass\", host;desc=\"cp1077\"", "strict-transport-security": "max-age=106384710; includeSubDomains; preload", "report-to": "{ \"group\": \"wm_nel\", \"max_age\": 604800, \"endpoints\": [{ \"url\": \"https://intake-logging.wikimedia.org/v1/events?stream=w3c.reportingapi.network_error&schema_uri=/w3c/reportingapi/network_error/1.0.0\" }] }", "nel": "{ \"report_to\": \"wm_nel\", \"max_age\": 604800, \"failure_fraction\": 0.05, \"success_fraction\": 0.0}", "x-client-ip": "74.71.26.214"} }
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/bad_request#rerenders_disabled","method":"get","detail":"Rerenders for this article are blacklisted in the config.","uri":"/commons.wikimedia.org/v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AHalle_(Saale)_-_Landgericht_-_Treppenhaus_-_Decke_(2128).jpg"}

So it's clearly still banned in the configuration somewhere, but where is it coming from? Why are pages still banned from being re-rendered?

Event Timeline

The original example I mentioned no longer works, somehow something was able to upgrade it to 2.7.0, so it no longer errors. But today I can hit this on https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ABloemknoppen_van_een_vlier_(Sambucus_serenade)._14-04-2021_(actm.)_01.jpg (still 2.6.0)

2023-03-29T05:53:06.396885Z DEBUG parsoid::api: req=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured%20picture%20candidates%2FFile%3ABloemknoppen%20van%20een%20vlier%20%28Sambucus%20serenade%29.%2014-04-2021%20%28actm.%29%2001.jpg", query: Some("redirect=false"), fragment: None }, headers: {"accept": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\""} }
2023-03-29T05:53:06.548600Z DEBUG parsoid::api: resp=Response { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ABloemknoppen_van_een_vlier_(Sambucus_serenade)._14-04-2021_(actm.)_01.jpg", query: Some("redirect=false"), fragment: None }, status: 403, headers: {"access-control-allow-origin": "*", "access-control-allow-methods": "GET,HEAD", "access-control-allow-headers": "accept, content-type, content-length, cache-control, accept-language, api-user-agent, if-match, if-modified-since, if-none-match, dnt, accept-encoding", "access-control-expose-headers": "etag", "x-content-type-options": "nosniff", "x-frame-options": "SAMEORIGIN", "referrer-policy": "origin-when-cross-origin", "x-xss-protection": "1; mode=block", "content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-webkit-csp": "default-src 'none'; frame-ancestors 'none'", "content-location": "https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ABloemknoppen_van_een_vlier_(Sambucus_serenade)._14-04-2021_(actm.)_01.jpg", "cache-control": "private, max-age=0, s-maxage=0, must-revalidate", "server": "restbase1031", "content-type": "application/problem+json", "content-length": "336", "date": "Wed, 29 Mar 2023 05:53:07 GMT", "age": "0", "x-cache": "cp1087 miss, cp1077 pass", "x-cache-status": "pass", "server-timing": "cache;desc=\"pass\", host;desc=\"cp1077\"", "strict-transport-security": "max-age=106384710; includeSubDomains; preload", "report-to": "{ \"group\": \"wm_nel\", \"max_age\": 604800, \"endpoints\": [{ \"url\": \"https://intake-logging.wikimedia.org/v1/events?stream=w3c.reportingapi.network_error&schema_uri=/w3c/reportingapi/network_error/1.0.0\" }] }", "nel": "{ \"report_to\": \"wm_nel\", \"max_age\": 604800, \"failure_fraction\": 0.05, \"success_fraction\": 0.0}", "x-client-ip": "74.71.26.214"} }
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/bad_request#rerenders_disabled","method":"get","detail":"Rerenders for this article are blacklisted in the config.","uri":"/commons.wikimedia.org/v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ABloemknoppen_van_een_vlier_(Sambucus_serenade)._14-04-2021_(actm.)_01.jpg"}

https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg is 2.6.0:

2023-03-29T06:00:16.040962Z DEBUG parsoid::api: req=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured%20picture%20candidates%2FFile%3ASwamp%20rose-mallow.jpg", query: Some("redirect=false"), fragment: None }, headers: {"accept": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\""} }
2023-03-29T06:00:16.185621Z DEBUG parsoid::api: resp=Response { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg", query: Some("redirect=false"), fragment: None }, status: 403, headers: {"access-control-allow-origin": "*", "access-control-allow-methods": "GET,HEAD", "access-control-allow-headers": "accept, content-type, content-length, cache-control, accept-language, api-user-agent, if-match, if-modified-since, if-none-match, dnt, accept-encoding", "access-control-expose-headers": "etag", "x-content-type-options": "nosniff", "x-frame-options": "SAMEORIGIN", "referrer-policy": "origin-when-cross-origin", "x-xss-protection": "1; mode=block", "content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-webkit-csp": "default-src 'none'; frame-ancestors 'none'", "content-location": "https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg", "cache-control": "private, max-age=0, s-maxage=0, must-revalidate", "server": "restbase1033", "content-type": "application/problem+json", "content-length": "284", "date": "Wed, 29 Mar 2023 06:00:17 GMT", "age": "0", "x-cache": "cp1075 miss, cp1077 pass", "x-cache-status": "pass", "server-timing": "cache;desc=\"pass\", host;desc=\"cp1077\"", "strict-transport-security": "max-age=106384710; includeSubDomains; preload", "report-to": "{ \"group\": \"wm_nel\", \"max_age\": 604800, \"endpoints\": [{ \"url\": \"https://intake-logging.wikimedia.org/v1/events?stream=w3c.reportingapi.network_error&schema_uri=/w3c/reportingapi/network_error/1.0.0\" }] }", "nel": "{ \"report_to\": \"wm_nel\", \"max_age\": 604800, \"failure_fraction\": 0.05, \"success_fraction\": 0.0}", "x-client-ip": "74.71.26.214"} }
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/bad_request#rerenders_disabled","method":"get","detail":"Rerenders for this article are blacklisted in the config.","uri":"/commons.wikimedia.org/v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg"}

I ran my script again, and presto, it works!

2023-03-29T06:02:39.626681Z DEBUG parsoid::api: req=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured%20picture%20candidates%2FFile%3ASwamp%20rose-mallow.jpg", query: Some("redirect=false"), fragment: None }, headers: {"accept": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\""} }
2023-03-29T06:02:40.294823Z DEBUG parsoid::api: resp=Response { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg", query: Some("redirect=false"), fragment: None }, status: 200, headers: {"content-type": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\"", "content-language": "en", "cache-control": "s-maxage=1209600, max-age=0, must-revalidate", "access-control-allow-origin": "*", "access-control-allow-methods": "GET,HEAD", "access-control-allow-headers": "accept, content-type, content-length, cache-control, accept-language, api-user-agent, if-match, if-modified-since, if-none-match, dnt, accept-encoding", "access-control-expose-headers": "etag", "x-content-type-options": "nosniff", "x-frame-options": "SAMEORIGIN", "referrer-policy": "origin-when-cross-origin", "x-xss-protection": "1; mode=block", "content-security-policy": "default-src 'none'; media-src *; img-src *; style-src http://*.wikimedia.org https://*.wikimedia.org 'unsafe-inline';frame-ancestors 'self'", "x-content-security-policy": "default-src 'none'; media-src *; img-src *; style-src http://*.wikimedia.org https://*.wikimedia.org 'unsafe-inline';frame-ancestors 'self'", "x-webkit-csp": "default-src 'none'; media-src *; img-src *; style-src http://*.wikimedia.org https://*.wikimedia.org 'unsafe-inline';frame-ancestors 'self'", "content-location": "https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3ASwamp_rose-mallow.jpg", "server": "restbase1021", "date": "Wed, 29 Mar 2023 06:02:41 GMT", "etag": "W/\"531256541/50b30880-cdf7-11ed-80c9-3d0fe51a9d22\"", "accept-ranges": "bytes", "vary": "Accept, Accept-Encoding", "age": "1", "x-cache": "cp1085 miss, cp1077 pass", "x-cache-status": "pass", "server-timing": "cache;desc=\"pass\", host;desc=\"cp1077\"", "strict-transport-security": "max-age=106384710; includeSubDomains; preload", "report-to": "{ \"group\": \"wm_nel\", \"max_age\": 604800, \"endpoints\": [{ \"url\": \"https://intake-logging.wikimedia.org/v1/events?stream=w3c.reportingapi.network_error&schema_uri=/w3c/reportingapi/network_error/1.0.0\" }] }", "nel": "{ \"report_to\": \"wm_nel\", \"max_age\": 604800, \"failure_fraction\": 0.05, \"success_fraction\": 0.0}", "x-client-ip": "74.71.26.214"} }

Now I've hit:

2023-03-29T06:03:44.125340Z DEBUG parsoid::api: req=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured%20picture%20candidates%2FFile%3AFCAB%20GL26C-2%202005%2C%202010%20and%20GT22CU-3%202402%20Salar%20de%20Carcote.jpg", query: Some("redirect=false"), fragment: None }, headers: {"accept": "text/html; charset=utf-8; profile=\"https://www.mediawiki.org/wiki/Specs/HTML/2.7.0\""} }
2023-03-29T06:03:44.305894Z DEBUG parsoid::api: resp=Response { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("commons.wikimedia.org")), port: None, path: "/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AFCAB_GL26C-2_2005%2C_2010_and_GT22CU-3_2402_Salar_de_Carcote.jpg", query: Some("redirect=false"), fragment: None }, status: 403, headers: {"access-control-allow-origin": "*", "access-control-allow-methods": "GET,HEAD", "access-control-allow-headers": "accept, content-type, content-length, cache-control, accept-language, api-user-agent, if-match, if-modified-since, if-none-match, dnt, accept-encoding", "access-control-expose-headers": "etag", "x-content-type-options": "nosniff", "x-frame-options": "SAMEORIGIN", "referrer-policy": "origin-when-cross-origin", "x-xss-protection": "1; mode=block", "content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-content-security-policy": "default-src 'none'; frame-ancestors 'none'", "x-webkit-csp": "default-src 'none'; frame-ancestors 'none'", "content-location": "https://commons.wikimedia.org/api/rest_v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AFCAB_GL26C-2_2005%2C_2010_and_GT22CU-3_2402_Salar_de_Carcote.jpg", "cache-control": "private, max-age=0, s-maxage=0, must-revalidate", "server": "restbase1032", "content-type": "application/problem+json", "content-length": "327", "date": "Wed, 29 Mar 2023 06:03:45 GMT", "age": "0", "x-cache": "cp1081 miss, cp1077 pass", "x-cache-status": "pass", "server-timing": "cache;desc=\"pass\", host;desc=\"cp1077\"", "strict-transport-security": "max-age=106384710; includeSubDomains; preload", "report-to": "{ \"group\": \"wm_nel\", \"max_age\": 604800, \"endpoints\": [{ \"url\": \"https://intake-logging.wikimedia.org/v1/events?stream=w3c.reportingapi.network_error&schema_uri=/w3c/reportingapi/network_error/1.0.0\" }] }", "nel": "{ \"report_to\": \"wm_nel\", \"max_age\": 604800, \"failure_fraction\": 0.05, \"success_fraction\": 0.0}", "x-client-ip": "74.71.26.214"} }
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/bad_request#rerenders_disabled","method":"get","detail":"Rerenders for this article are blacklisted in the config.","uri":"/commons.wikimedia.org/v1/page/html/Commons%3AFeatured_picture_candidates%2FFile%3AFCAB_GL26C-2_2005%2C_2010_and_GT22CU-3_2402_Salar_de_Carcote.jpg"}

known bad servers: restbase1031, restbase1032, restbase1033.

I poked a bit, is it possible these servers weren't picking up restbase changes somehow?

legoktm@cumin1001:~$ sudo cumin A:restbase 'grep renderBlacklist /srv/deployment/restbase/deploy/restbase/projects/sys/default.wmf.yaml'
34 hosts will be targeted:
restbase[2012-2027].codfw.wmnet,restbase[1016-1033].eqiad.wmnet
OK to proceed on 34 hosts? Enter the number of affected hosts to confirm or "q" to quit: 34
===== NODE GROUP =====                                                                                                                                                                                                                        
(4) restbase2027.codfw.wmnet,restbase[1031-1033].eqiad.wmnet                                                                                                                                                                                  
----- OUTPUT of 'grep renderBlack...default.wmf.yaml' -----                                                                                                                                                                                   
          rerenderBlacklist:                                                                                                                                                                                                                  
===== NODE GROUP =====                                                                                                                                                                                                                        
(30) restbase[2012-2026].codfw.wmnet,restbase[1016-1030].eqiad.wmnet                                                                                                                                                                          
----- OUTPUT of 'grep renderBlack...default.wmf.yaml' -----                                                                                                                                                                                   
          rerenderBlacklist: {}                                                                                                                                                                                                               
================

So for some reason, restbase2027.codfw.wmnet,restbase[1031-1033].eqiad.wmnet are missing a configuration change that was supposed to be deployed back in October!

legoktm@cumin1001:~$ sudo cumin A:restbase 'sudo -u deploy-service git -C /srv/deployment/restbase/deploy/restbase log -n1'
34 hosts will be targeted:
restbase[2012-2027].codfw.wmnet,restbase[1016-1033].eqiad.wmnet
OK to proceed on 34 hosts? Enter the number of affected hosts to confirm or "q" to quit: 34
===== NODE GROUP =====                                                                                                                                                                                                                        
(4) restbase2027.codfw.wmnet,restbase[1031-1033].eqiad.wmnet                                                                                                                                                                                  
----- OUTPUT of 'sudo -u deploy-s...restbase log -n1' -----                                                                                                                                                                                   
commit 03a9a785fcc7180481420409d823a66a11cf2a65                                                                                                                                                                                               
Merge: fd0cb63c a98d91fe                                                                                                                                                                                                                      
Author: Clara <candrewwani@gmail.com>
Date:   Tue Aug 31 08:48:19 2021 -0500

    Merge pull request #1294 from wikimedia/mt
    
    Bump mediawiki-title to v0.7.4
===== NODE GROUP =====                                                                                                                                                                                                                        
(30) restbase[2012-2026].codfw.wmnet,restbase[1016-1030].eqiad.wmnet                                                                                                                                                                          
----- OUTPUT of 'sudo -u deploy-s...restbase log -n1' -----                                                                                                                                                                                   
commit c1d391c74d39d38f7b1a8175e510fa714b4d91f1                                                                                                                                                                                               
Merge: 73bd40bd 6d95dfff                                                                                                                                                                                                                      
Author: John Giannelos <jgiannelos@wikimedia.org>
Date:   Tue Oct 18 16:06:07 2022 +0200

    Merge pull request #1310 from johngian/fix-timing
    
    pcs: Fix timing metric
================
legoktm@cumin1001:~$ sudo cumin A:restbase 'sudo -u deploy-service git -C /srv/deployment/restbase/deploy log -n1'
34 hosts will be targeted:
restbase[2012-2027].codfw.wmnet,restbase[1016-1033].eqiad.wmnet
OK to proceed on 34 hosts? Enter the number of affected hosts to confirm or "q" to quit: 34
===== NODE GROUP =====                                                                                                                                                                                                                        
(1) restbase2027.codfw.wmnet                                                                                                                                                                                                                  
----- OUTPUT of 'sudo -u deploy-s...e/deploy log -n1' -----                                                                                                                                                                                   
commit 6e39559822f7f7191850762774540812b8bca8c5                                                                                                                                                                                               
Author: Alexander Vorwerk <zabe@avorwerk.net>                                                                                                                                                                                                 
Date:   Mon May 16 16:55:28 2022 +0200

    Add kcgwiki to RESTBase
    
    Bug: T305281
    Change-Id: I763a3db189ae43efd2ceb5741f5455c0892e64ef
===== NODE GROUP =====                                                                                                                                                                                                                        
(3) restbase[1031-1033].eqiad.wmnet                                                                                                                                                                                                           
----- OUTPUT of 'sudo -u deploy-s...e/deploy log -n1' -----                                                                                                                                                                                   
commit a571f9a9c37b5c40640d5fea1ce3b7bff64645da                                                                                                                                                                                               
Author: Alexander Vorwerk <zabe@avorwerk.net>                                                                                                                                                                                                 
Date:   Tue Jul 19 17:13:12 2022 +0200

    Add blkwiki to RESTBase
    
    Bug: T310874
    Change-Id: I5d5902916812332569ec907fcb5af8cb5b35db93
===== NODE GROUP =====                                                                                                                                                                                                                        
(30) restbase[2012-2026].codfw.wmnet,restbase[1016-1030].eqiad.wmnet                                                                                                                                                                          
----- OUTPUT of 'sudo -u deploy-s...e/deploy log -n1' -----                                                                                                                                                                                   
commit f7747116c9c5ccf8b96835f63d19fe5da84af2c8                                                                                                                                                                                               
Merge: 5271b8fd2 ee218c0dd                                                                                                                                                                                                                    
Author: Jgiannelos <jgiannelos@wikimedia.org>
Date:   Thu Mar 9 12:54:58 2023 +0000

    Merge "experimental: Disable mobile-html storage on ptwiki"
================
Legoktm triaged this task as Unbreak Now! priority.Mar 29 2023, 6:33 AM

Marking as UBN so this can be triaged appropriately. Not having deployments since at least October, probably earlier, presumably means that entire wikis are missing.

Legoktm renamed this task from HTTP 403 "Rerenders for this article are blacklisted in the config." via restbase for specific Commons pages to Multiple restbase servers have not received any deployments since at least October 2022.Mar 29 2023, 6:34 AM

Very simply, those 3 servers are not in the targets file for deployment.

Change 904006 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[mediawiki/services/restbase/deploy@master] Add missing targets

https://gerrit.wikimedia.org/r/904006

Change 904006 merged by Giuseppe Lavagetto:

[mediawiki/services/restbase/deploy@master] Add missing targets

https://gerrit.wikimedia.org/r/904006

Mentioned in SAL (#wikimedia-operations) [2023-03-29T06:59:12Z] <oblivian@deploy2002> Started deploy [restbase/deploy@11477d6]: Updating stale nodes, T333069

Adding @hnowlan as FYI so that we are careful about this in the future.

I would add that probably it's not worth trying to solve this issue, but I always considered the fact that targets need to be defined in the deployment repositories the biggest footgun of "scap3".

Joe claimed this task.

All stale nodes have been updated.

Mentioned in SAL (#wikimedia-operations) [2023-03-29T07:31:20Z] <oblivian@deploy2002> Finished deploy [restbase/deploy@11477d6]: Updating stale nodes, T333069 (duration: 32m 07s)