<follow up task> Add tests to cover the changes and new introductions from the patches related to https://phabricator.wikimedia.org/T311160. During that task to deliver early we descoped this, but tests are important to make sure that we can maintain this and it won't break in future.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| popupNotification Javascript tests | mediawiki/skins/Vector | master | +169 -1 |
Related Objects
Related Objects
Event Timeline
Comment Actions
@Mabualruz: Assuming this task is about the Vector2022 code base, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!
Comment Actions
I believe popupNotifications.js also has a memory leak because we create new popup widgets each time we show the popup, and since the OOUI popupwidget doesnt have a destructor, we just remove the popup from the DOM. Could we also fix that with this task? I believe the simplest solution is to store an array of all popupWidgets, so that we dont reinitialize new widgets each time a popup notification is created
Comment Actions
Change 909425 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/Vector@master] popupNotification Javascript tests
Comment Actions
Change 909425 merged by jenkins-bot:
[mediawiki/skins/Vector@master] popupNotification Javascript tests