Page MenuHomePhabricator
Create Task
Maniphest T333651

🏷️ Add request validation to label edits
Closed, ResolvedPublic
Actions

Description

  • validate:
    • item id
    • language code
    • label (see parent story: empty or too long)
    • metadata (edit comment, tags, bot flag)

Details

SubjectRepoBranchLines +/-
REST: Add label validation to SetItemLabelmediawiki/extensions/Wikibasemaster+572 -88
REST: Add request validation to label editsmediawiki/extensions/Wikibasemaster+491 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Mar 31 2023, 8:16 AM
• WMDE_Norman claimed this task.Apr 13 2023, 11:41 AM
• WMDE_Norman moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 26) board.
gerritbot added a comment.Apr 14 2023, 11:17 AM

Change 908800 had a related patch set uploaded (by Norman Schwirz; author: Norman Schwirz):

[mediawiki/extensions/Wikibase@master] REST: Add request validation to label edits

https://gerrit.wikimedia.org/r/908800

gerritbot added a project: Patch-For-Review.Apr 14 2023, 11:17 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 27); removed Wikibase Product Platform (v1) (Sprint 26).Apr 18 2023, 10:52 AM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 27) board.Apr 18 2023, 10:53 AM
• WMDE_Norman moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 27) board.Apr 25 2023, 3:10 PM
gerritbot added a comment.Apr 26 2023, 3:44 PM

Change 912324 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Add collision detection to SetItemLabel

https://gerrit.wikimedia.org/r/912324

gerritbot added a comment.Apr 27 2023, 10:20 AM

Change 908800 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add request validation to label edits

https://gerrit.wikimedia.org/r/908800

gerritbot added a comment.Apr 28 2023, 8:41 AM

Change 912324 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add label validation to SetItemLabel

https://gerrit.wikimedia.org/r/912324

Silvan_WMDE closed this task as Resolved.Apr 28 2023, 9:05 AM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 27) board.
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2023, 9:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL