Page MenuHomePhabricator
Create Task
Maniphest T333661

Make Wikibase available in EntitySchema CI
Closed, ResolvedPublic
Actions

Description

Based on ADR 0003, we want EntitySchema to make use of Wikibase's hooks for adding a new Datatype. To be able to test that integration, we need Wikibase to be available during the CI runs of the EntitySchema extension

Open Question:

  • Is there a point to running the Wikibase tests too, during EntitySchema CI runs? If no, can we reasonably prevent that?

Details

SubjectRepoBranchLines +/-
Zuul: [mediawiki/extensions/EntitySchema] Add Wikibase depintegration/configmaster+2 -0
build: Add Wikibase PHP files to phan config now it's cloned for usmediawiki/extensions/EntitySchemamaster+22 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Mar 31 2023, 9:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2023, 9:26 AM
Michael moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Mar 31 2023, 4:09 PM
Arian_Bozorg moved this task from incoming to ready to go on the Wikidata board.Apr 5 2023, 10:28 AM
Lucas_Werkmeister_WMDE claimed this task.Apr 5 2023, 2:53 PM
Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Apr 5 2023, 2:56 PM

Change 906041 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Add Wikibase dep

https://gerrit.wikimedia.org/r/906041

gerritbot added a project: Patch-For-Review.Apr 5 2023, 2:56 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Apr 5 2023, 2:57 PM
gerritbot added a comment.Apr 5 2023, 5:55 PM

Change 906041 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Add Wikibase dep

https://gerrit.wikimedia.org/r/906041

Stashbot added a comment.Apr 5 2023, 6:05 PM

Mentioned in SAL (#wikimedia-releng) [2023-04-05T18:05:47Z] <James_F> Zuul: [mediawiki/extensions/EntitySchema] Add Wikibase dep, for T333661

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2023, 6:10 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Apr 6 2023, 9:46 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 6 2023, 12:26 PM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

Looks like Wikibase is indeed being added to EntitySchema CI runs now, so closing.

gerritbot added a comment.Apr 10 2023, 2:35 PM

Change 907487 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/EntitySchema@master] build: Add Wikibase PHP files to phan config now it's cloned for us

https://gerrit.wikimedia.org/r/907487

gerritbot added a project: Patch-For-Review.Apr 10 2023, 2:35 PM
Lucas_Werkmeister_WMDE mentioned this in T334464: EntitySchema PHPUnit tests fail when FlaggedRevs is installed.Apr 11 2023, 10:39 AM
Michael mentioned this in T334575: SyntaxHighlight adds trailing newline, breaking browser tests.Apr 12 2023, 11:59 AM
gerritbot added a comment.Apr 12 2023, 2:33 PM

Change 907487 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] build: Add Wikibase PHP files to phan config now it's cloned for us

https://gerrit.wikimedia.org/r/907487

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 3:11 PM
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.May 12 2023, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits