AQS 2.0: convert Device Analytics router from fasthttp to mux
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	BPirkle
	Mar 31 2023, 4:16 PM

Description

Per T328166: AQS 2.0: Reevaluate Go router package, we are converting the router for all the AQS 2.0 services from fasthttp to gorilla/mux. See that task for rationale.

This task covers conversion of the Device Analytics service.

Completion criteria:

router is converted
handlers are adjusted to use the standard interface
any modifications to tests are completed
"make test" passes
"make itest" passes

QA needs: this should have no external effect for callers. It is sufficient to ensure that there are no regressions, and that caller-facing functionality is not changed.

Details

	Subject	Repo	Branch	Lines +/-
	Resolving issues on main branch	generated-data-platform/aqs/device-analytics	main	+22 -20
	This change covers - Router changes from fasthttp to gorilla/mux Some minor restructuring	generated-data-platform/aqs/device-analytics	main	+210 -203

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T324931 Clean up open RESTBase related tickets
In Progress	None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
In Progress	None	T263489 AQS 2.0
Resolved	SGupta-WMF	T288298 AQS 2.0: Device Analytics service
Resolved	EChukwukere-WMF	T333705 AQS 2.0: convert Device Analytics router from fasthttp to mux

Event Timeline

BPirkle created this task.Mar 31 2023, 4:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2023, 4:16 PM

VirginiaPoundstone moved this task from Incoming to Needs Grooming on the API Platform board.Mar 31 2023, 6:26 PM

VirginiaPoundstone moved this task from Needs Grooming to Sprint 07 on the API Platform board.Apr 4 2023, 2:36 PM

VirginiaPoundstone edited projects, added API Platform (Sprint 07); removed API Platform.

JArguello-WMF moved this task from Incoming to In Current Sprint on the AQS2.0 board.Apr 6 2023, 5:33 PM

SGupta-WMF claimed this task.Apr 11 2023, 9:19 AM

SGupta-WMF moved this task from Next Up to In Progress on the API Platform (Sprint 07) board.Apr 12 2023, 3:55 AM

Change 909617 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/device-analytics@main] Bug : T333705

https://gerrit.wikimedia.org/r/909617

Change 909618 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/device-analytics@main] Bug : T333705

https://gerrit.wikimedia.org/r/909618

Change 909617 abandoned by Sg912:

[generated-data-platform/aqs/device-analytics@main] Bug : T333705

Reason:

Multiple MRs same topic

https://gerrit.wikimedia.org/r/909617

SGupta-WMF changed the task status from Open to In Progress.Apr 18 2023, 9:38 AM

SGupta-WMF moved this task from In Progress to Ready for Code Review/ Ready for Tech input on the API Platform (Sprint 07) board.

SGupta-WMF reassigned this task from SGupta-WMF to BPirkle.Apr 18 2023, 9:41 AM

SGupta-WMF subscribed.

Change 909618 had a related patch set uploaded (by BPirkle; author: Sg912):

[generated-data-platform/aqs/device-analytics@main] This change covers - Router changes from fasthttp to gorilla/mux Some minor restructuring

https://gerrit.wikimedia.org/r/909618

Change 909618 merged by BPirkle:

[generated-data-platform/aqs/device-analytics@main] This change covers - Router changes from fasthttp to gorilla/mux Some minor restructuring

https://gerrit.wikimedia.org/r/909618

Change 910894 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/device-analytics@main] Resolving issues on main branch

https://gerrit.wikimedia.org/r/910894

Change 910894 merged by BPirkle:

[generated-data-platform/aqs/device-analytics@main] Resolving issues on main branch

https://gerrit.wikimedia.org/r/910894

BPirkle reassigned this task from BPirkle to EChukwukere-WMF.Apr 24 2023, 3:28 PM

BPirkle updated the task description. (Show Details)

BPirkle moved this task from Ready for Code Review/ Ready for Tech input to Ready for Testing on the API Platform (Sprint 07) board.

@BPirkle I made some additional changes to restrict routers to use only GET . And I thought its better to do it before QA so reassigning this for code review.
Apologies for causing inconvenience and asking for multiple review cycles.

SGupta-WMF moved this task from Ready for Testing to In code Review/ Tech Input on the API Platform (Sprint 07) board.Apr 25 2023, 6:34 AM

JArguello-WMF moved this task from In code Review/ Tech Input to Ready for Testing on the API Platform (Sprint 07) board.Apr 26 2023, 12:44 PM

SGupta-WMF moved this task from Ready for Testing to In code Review/ Tech Input on the API Platform (Sprint 07) board.Apr 26 2023, 2:13 PM

JArguello-WMF edited projects, added AQS2.0 (Sprint 10); removed API Platform (Sprint 07), AQS2.0.Apr 26 2023, 2:57 PM

JArguello-WMF moved this task from Next Up to In code Review/ Tech Input on the AQS2.0 (Sprint 10) board.

In T333705#8803664, @SGupta-WMF wrote:

@BPirkle I made some additional changes to restrict routers to use only GET . And I thought its better to do it before QA so reassigning this for code review.
Apologies for causing inconvenience and asking for multiple review cycles.

Glad you did, that was a good addition, thanks for thinking of it.

Reviewed, merged, reassigning to QA.

EChukwukere-WMF moved this task from Ready for Testing to In Testing on the AQS2.0 (Sprint 10) board.May 5 2023, 3:20 PM

Test status: QA PASS

Tests works as expected

EChukwukere-WMF moved this task from In Testing to Done on the AQS2.0 (Sprint 10) board.May 8 2023, 3:44 AM

Atieno added a parent task: T288298: AQS 2.0: Device Analytics service.May 10 2023, 1:55 PM

Atieno mentioned this in T335505: Figure out what's outstanding to have device-analytics serving 100% Production data.May 10 2023, 2:31 PM

JArguello-WMF closed this task as Resolved.May 17 2023, 2:49 PM