Maniphest T333809

DefaultView: Empty ZMonolingualString with no language doesn't show empty language chip
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	gengh
	Apr 3 2023, 10:17 AM

Tags

Referenced Files

	F36937705: Screenshot from 2023-04-03 12-14-18.png
	Apr 3 2023, 10:17 AM

	F36937701: Screenshot from 2023-04-03 12-12-58.png
	Apr 3 2023, 10:17 AM

Subscribers

Description

Description

When having a zero state monolingual string (no language set), the input doesn't have the empty language chip:

Screenshot from 2023-04-03 12-12-58.png (77×289 px, 2 KB)

As specified in the designs:

Screenshot from 2023-04-03 12-14-18.png (248×319 px, 14 KB)

Devices and Design (URLs or screenshots, if applicable):

https://www.figma.com/file/uNBSv1e4ceA8tGNr29R9vp/T306442-Default-view?node-id=3011-54601&t=0uPBmpY7V0I5kbym-0

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	Fix ZMonolingualString styles when language is unset	mediawiki/extensions/WikiLambda	master	+59 -23

Customize query in gerrit

Event Timeline

gengh created this task.Apr 3 2023, 10:17 AM

Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Apr 3 2023, 4:07 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.

Change 907889 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix ZMonolingualString styles when language is unset

https://gerrit.wikimedia.org/r/907889

gerritbot added a project: Patch-For-Review.Apr 11 2023, 1:59 PM

Jdforrester-WMF assigned this task to gengh.Apr 11 2023, 2:20 PM

Jdforrester-WMF moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.

Change 907889 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ZMonolingualString styles when language is unset

https://gerrit.wikimedia.org/r/907889

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2023, 2:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 11 2023, 3:00 PM

It may sound silly, but this is really beautiful and such commitment to detail. I love it.