Page MenuHomePhabricator
Create Task
Maniphest T333881

Create account icon missing on pt.wikinews.org
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2023-04-03 at 1.31.53 PM.png (412×1 px, 283 KB)

How to fix
The fix should be in the Minerva repository. The icon is not being added to the stylesheet of the page and needs to be registered in one of the icon packs in skin.json

What should have happened instead?:
Icon should be present

sign off steps

Details

Other Assignee
Jdlrobson
SubjectRepoBranchLines +/-
Add missing Create account icon on pt.wikinews.orgmediawiki/skins/MinervaNeuemaster+1 -0
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 3 2023, 8:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2023, 8:32 PM
Jdlrobson updated the task description. (Show Details)Apr 3 2023, 8:33 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptApr 3 2023, 8:33 PM
Jdlrobson triaged this task as Medium priority.Apr 3 2023, 8:39 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson added projects: good first task, patch-welcome.Apr 5 2023, 5:14 PM
Jdlrobson updated the task description. (Show Details)
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.Apr 6 2023, 5:50 PM
Jdlrobson moved this task from Current Fiscal Year to Web Team FY2022-23 Q4 Sprint 2 on the Web-Team-Backlog board.Apr 10 2023, 9:59 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog.
gerritbot added a comment.Apr 15 2023, 1:04 PM

Change 908948 had a related patch set uploaded (by Klein Muçi; author: Klein Muçi):

[mediawiki/skins/MinervaNeue@master] T333881

https://gerrit.wikimedia.org/r/908948

gerritbot added a project: Patch-For-Review.Apr 15 2023, 1:04 PM
Klein subscribed.Apr 15 2023, 1:37 PM

@Jdlrobson, is my patch the right way to fix this?

gerritbot added a comment.Apr 17 2023, 4:09 PM

Change 908948 had a related patch set uploaded (by Jdlrobson; author: Klein Muçi):

[mediawiki/skins/MinervaNeue@master] Add missing Create account icon on pt.wikinews.org

https://gerrit.wikimedia.org/r/908948

Jdlrobson added a comment.Apr 17 2023, 4:09 PM
In T333881#8783552, @Klein wrote:

@Jdlrobson, is my patch the right way to fix this?

Looks great! I'll review it by the end of today!

LGoto set the point value for this task to 1.Apr 17 2023, 5:32 PM
gerritbot added a comment.Apr 17 2023, 9:40 PM

Change 908948 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add missing Create account icon on pt.wikinews.org

https://gerrit.wikimedia.org/r/908948

Jdlrobson assigned this task to Klein.Apr 17 2023, 9:52 PM
Jdlrobson updated Other Assignee, added: Jdlrobson.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.

I will QA this on Thursday and remove the ptwiki override per sign off steps.

Jdlrobson closed this task as Resolved.Apr 24 2023, 5:38 PM
Jdlrobson moved this task from QA to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Jdlrobson edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).

I verified the fix and removed it on Friday.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL