Page MenuHomePhabricator
Create Task
Maniphest T334489

DefaultView: Create ZTester View and Component
Closed, ResolvedPublic
Actions

Description

Description

  • Create ZTester custom component following the same patterns as other default/* components created for the DefaultView
  • Create ZTester view page, which shows the ZTester component as central content, plus other widgets that enrich the tester creation:
    • function explorer widget
    • implementation results widget
    • direct navigation with url setup of function ID
    • etc

Desired behavior/Acceptance criteria

  • Objects of type Z20/Tester should be rendered by default with this component in both edit and view mode
  • Styles according to the attached designs*

Devices and Design (URLs or screenshots)

Figma: https://www.figma.com/file/6gTBJnC187UBURVBdZ73NR/T334489-Tester-view-and-component?node-id=38-6058&t=VLX5FJJcNtoolwZy-0

Completion checklist

Details

SubjectRepoBranchLines +/-
Add Tester Componentmediawiki/extensions/WikiLambdamaster+299 -0
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Apr 11 2023, 3:43 PM
gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Apr 11 2023, 3:46 PM
gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.
AAlhazwani-WMF claimed this task.Apr 14 2023, 12:51 PM
AAlhazwani-WMF updated the task description. (Show Details)Apr 17 2023, 1:14 PM

the tester component is built on top of the previous designs, and solutions reached for the implementation component. specifically, the implementation component of type composition. the only difference is that the tester component has two compositions instead: one for the function call, and one for the result validation. figma file attached to the task description!

image.png (962×2 px, 238 KB)

AAlhazwani-WMF mentioned this in T323806: Design: create tests.Apr 17 2023, 2:15 PM
AAlhazwani-WMF removed AAlhazwani-WMF as the assignee of this task.Apr 18 2023, 10:04 AM
AAlhazwani-WMF removed a project: Design.
AAlhazwani-WMF subscribed.

task ready to be picked up by engineering!

gengh claimed this task.Apr 25 2023, 8:48 AM
gerritbot added a comment.Apr 25 2023, 1:38 PM

Change 911863 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add Tester Component

https://gerrit.wikimedia.org/r/911863

gerritbot added a project: Patch-For-Review.Apr 25 2023, 1:38 PM
gerritbot added a comment.Apr 28 2023, 3:38 PM

Change 911863 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add Tester Component

https://gerrit.wikimedia.org/r/911863

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2023, 4:10 PM
gengh moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.May 15 2023, 3:17 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 1:01 AM
DVrandecic subscribed.May 18 2023, 11:06 PM

Looks great! Missing a list of implementations. Should we have a new task for that?

AAlhazwani-WMF added a comment.May 19 2023, 10:43 AM

@DVrandecic once we do the "switch" you'll find the list of implementations that you see at the bottom of this page for instance https://wikifunctions.beta.wmflabs.org/wiki/Z10620

DVrandecic closed this task as Resolved.May 19 2023, 10:51 PM

Yes, indeed! Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL