Page MenuHomePhabricator
Create Task
Maniphest T334550

Remove CentralNoticeTiming instrumentation
Closed, ResolvedPublic
Actions

Description

This was added in 2018 to help inform the perf survey in case it correlated with negative reports of perceived performance on page views.

Context: https://wikitech.wikimedia.org/wiki/Performance/Essay/Performance_survey_(2019).

The stream was never consumed from Kafka though (we don't use it in navtiming.py, and we don't keep it in Graphite or Prometheus either). This means we're instrumenting in in pageviews via navtiming.js and sending actual beacons to the server, but not using the data.

The beacon is indeed actively being sent by browsers when banners are displayed:
https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&var-schema=CentralNoticeTiming

To remove, based on https://codesearch.wmcloud.org/search/?q=CentralNoticeTiming:

  • Remove JS beacon dispatch code in mediawiki/extensions/NavigationTiming.git
  • Remove enabling of the topic in wmf-config, both from ext-EventLogging and ext-EventStreamConfig in operations/mediawiki-config.git.
  • Remove current schema in schemas/event/secondary.git.
  • Remove enablement of the topic for legacy eventlogging and refinery in operations/puppet.git.
  • Remove enablement of long-term sanitized preservation of the topic in analytics/refinery.git.
  • Empty old schema at https://meta.wikimedia.org/wiki/Schema:CentralNoticeTiming.
  • Delete long-term retention Hive table event_sanitized.centralnoticetiming.

Details

SubjectRepoBranchLines +/-
eventlogging: remove CentralNoticeTimingoperations/puppetproduction+0 -2
CentralNoticeTiming: remove Central Notice Timing in refineryanalytics/refinerymaster+0 -5
CentralNoticeTiming: Remove CentralNoticeTiming schemaschemas/event/secondarymaster+0 -190
Remove enabling of Central Notice Timing in wmf-configoperations/mediawiki-configmaster+0 -12
Remove sending CentralNoticeTiming.mediawiki/extensions/NavigationTimingmaster+0 -75
Customize query in gerrit

Event Timeline

Krinkle created this task.Apr 12 2023, 5:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2023, 5:28 AM
gerritbot added a comment.Apr 12 2023, 2:51 PM

Change 908254 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/extensions/NavigationTiming@master] Remove sending CentralNoticeTiming.

https://gerrit.wikimedia.org/r/908254

gerritbot added a project: Patch-For-Review.Apr 12 2023, 2:51 PM
gerritbot added a comment.Apr 12 2023, 5:53 PM

Change 908254 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Remove sending CentralNoticeTiming.

https://gerrit.wikimedia.org/r/908254

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 6:10 PM
Peter updated the task description. (Show Details)Apr 17 2023, 6:33 PM
larissagaulia assigned this task to • BAbiola-WMF.Apr 18 2023, 12:15 PM
larissagaulia added subscribers: • BAbiola-WMF, larissagaulia.

@Krinkle could you help @BAbiola-WMF get this done by providing some context and guidance, please?

Krinkle updated the task description. (Show Details)Apr 19 2023, 3:13 PM
Krinkle added a comment.Apr 19 2023, 3:22 PM

I've added the Codesearch results to the task description. These each affect different systems collectively known as the "Event Platform", run by various teams.

I've placed them in the order I believe is safe to deploy. For example, the first one is instrumentation that creates the events. The second one is server configuration that affects accepting of events from the client. Next is the schemas that first event processor uses for validation.

By default we keep event data for 90 days for privacy and legal reasons. The last two items relate to "sanitizer", which creates a copy of some events that we simplify and in some cases keep for longer. We'll remove that one last.

Having said that, the people who operate each part will perform review and make sure it goes out correctly so don't worry about the order too much. We can prepare patches for all of these together.

Except for the first one, which Peter did, these are config-only repos with no local setup or testing process. CI will lint them, beyond that it is applied directly to production after code review.

gerritbot added a comment.Apr 20 2023, 9:11 AM

Change 910427 had a related patch set uploaded (by Barakat Ajadi; author: Barakat Ajadi):

[operations/mediawiki-config@master] Remove enabling of Central Notice Timing in wmf-config

https://gerrit.wikimedia.org/r/910427

gerritbot added a project: Patch-For-Review.Apr 20 2023, 9:11 AM
larissagaulia moved this task from Inbox, needs triage to Doing: Goals on the Performance-Team board.Apr 24 2023, 6:19 PM
gerritbot added a comment.Apr 27 2023, 11:20 AM

Change 910427 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove enabling of Central Notice Timing in wmf-config

https://gerrit.wikimedia.org/r/910427

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2023, 11:30 AM
gerritbot added a comment.Apr 27 2023, 1:21 PM

Change 912852 had a related patch set uploaded (by Barakat Ajadi; author: Barakat Ajadi):

[schemas/event/secondary@master] CentralNoticeTiming: Remove CentralNoticeTiming schema

https://gerrit.wikimedia.org/r/912852

gerritbot added a project: Patch-For-Review.Apr 27 2023, 1:21 PM
Krinkle updated the task description. (Show Details)May 2 2023, 11:43 PM
gerritbot added a comment.May 2 2023, 11:44 PM

Change 912852 merged by jenkins-bot:

[schemas/event/secondary@master] CentralNoticeTiming: Remove CentralNoticeTiming schema

https://gerrit.wikimedia.org/r/912852

Maintenance_bot removed a project: Patch-For-Review.May 3 2023, 12:10 AM
gerritbot added a comment.May 4 2023, 9:44 PM

Change 915850 had a related patch set uploaded (by Barakat Ajadi; author: Barakat Ajadi):

[operations/puppet@production] CentralNoticeTiming: Remove enablement of the topic for legacy eventlogging and refinery

https://gerrit.wikimedia.org/r/915850

gerritbot added a project: Patch-For-Review.May 4 2023, 9:44 PM
gerritbot added a comment.May 9 2023, 10:59 AM

Change 917855 had a related patch set uploaded (by Barakat Ajadi; author: Barakat Ajadi):

[analytics/refinery@master] CentralNoticeTiming: remove Central Notice Timing in refinery

https://gerrit.wikimedia.org/r/917855

gerritbot added a comment.May 10 2023, 3:38 PM

Change 917855 merged by Milimetric:

[analytics/refinery@master] CentralNoticeTiming: remove Central Notice Timing in refinery

https://gerrit.wikimedia.org/r/917855

Krinkle updated the task description. (Show Details)May 10 2023, 5:30 PM
Milimetric updated the task description. (Show Details)May 11 2023, 4:22 PM
gerritbot added a comment.Jun 6 2023, 5:56 PM

Change 915850 merged by Ottomata:

[operations/puppet@production] eventlogging: remove CentralNoticeTiming

https://gerrit.wikimedia.org/r/915850

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 6:11 PM
• BAbiola-WMF closed this task as Resolved.Jun 12 2023, 11:38 AM
• BAbiola-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL