Notification overlay doesn't get removed when reduced motion is preferred
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	BrandonXLF
	Apr 13 2023, 1:00 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The overly moves off the screen, but it doesn't get removed. This prevents you from scrolling the page.

What should have happened instead?:
The overlay should be fully removed.

Software version (skip for WMF-hosted wikis like Wikipedia):

N/A

Other information (browser name/version, screenshots, etc.):

The overlay is not removed, it just moves off the page.

	Subject	Repo	Branch	Lines +/-
	Exit overlay immediately if no transition	mediawiki/extensions/Echo	master	+1 -1

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is caused by https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Echo/+/refs/heads/master/modules/mobile/overlay.js#16. transitionend should only be listened for if there's a transition with a duration (prefers-reduced-motion: reduce removes the transition duration).

Change 908581 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/extensions/Echo@master] Exit overlay immediately if no transition

Change 908581 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Exit overlay immediately if no transition

For checking after deploying the fix to production:

betalabs - the fix is in place (animated gif)	production wmf.5 - the issue is present (animated gif)
- the page is scrollable after dismissing the Notification overlay	- the page is NOT scrollable after dismissing the Notification overlay

Checked in wmf.6 - testwiki, cawiki and hewiki: the issue is fixed.

	F36957887: reduced_motion_production.gif
	Apr 21 2023, 12:19 AM