Page MenuHomePhabricator

Error: Call to a member function getComment() on null
Closed, ResolvedPublicPRODUCTION ERROR

Description

Started on April 14, 2023 and affects idwiki only as far as I can see, which around 12k errors as of this Task.

All pages affected by this error return a fatal error when trying to view them. Curiously, if you hit the edit tab and then save without making any change makes the fatal go away.

Error
labels.normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getComment() on null
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.4/extensions/Wikistories/includes/hooks/RecentChangesPropagationHooks.php(467)
#0 /srv/mediawiki/php-1.41.0-wmf.4/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\Wikistories\hooks\RecentChangesPropagationHooks->onOldChangesListRecentChangesLine(OldChangesList, string, RecentChange, array, array)
#1 /srv/mediawiki/php-1.41.0-wmf.4/includes/HookContainer/HookRunner.php(2625): MediaWiki\HookContainer\HookContainer->run(string, array)
#2 /srv/mediawiki/php-1.41.0-wmf.4/includes/changes/OldChangesList.php(60): MediaWiki\HookContainer\HookRunner->onOldChangesListRecentChangesLine(OldChangesList, string, RecentChange, array, array)
#3 /srv/mediawiki/php-1.41.0-wmf.4/includes/specials/SpecialRecentChanges.php(597): OldChangesList->recentChangesLine(RecentChange, boolean, integer)
#4 /srv/mediawiki/php-1.41.0-wmf.4/includes/specialpage/ChangesListSpecialPage.php(1585): SpecialRecentChanges->outputChangesList(Wikimedia\Rdbms\MysqliResultWrapper, MediaWiki\Html\FormOptions)
#5 /srv/mediawiki/php-1.41.0-wmf.4/includes/specialpage/ChangesListSpecialPage.php(681): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\MysqliResultWrapper, MediaWiki\Html\FormOptions)
#6 /srv/mediawiki/php-1.41.0-wmf.4/includes/specials/SpecialRecentChanges.php(208): ChangesListSpecialPage->execute(string)
#7 /srv/mediawiki/php-1.41.0-wmf.4/includes/specialpage/SpecialPage.php(701): SpecialRecentChanges->execute(string)
#8 /srv/mediawiki/php-1.41.0-wmf.4/includes/specialpage/SpecialPageFactory.php(1497): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.41.0-wmf.4/includes/MediaWiki.php(328): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#10 /srv/mediawiki/php-1.41.0-wmf.4/includes/MediaWiki.php(926): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.41.0-wmf.4/includes/MediaWiki.php(579): MediaWiki->main()
#12 /srv/mediawiki/php-1.41.0-wmf.4/index.php(50): MediaWiki->run()
#13 /srv/mediawiki/php-1.41.0-wmf.4/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
Impact
Notes

Details

MediaWiki Version
1.41.0-wmf.4
Request URL
https://id.wikipedia.org/wiki/Istimewa:Perubahan_terkait/Pembicaraan:Gabusan,_Jati,_Blora

Event Timeline

SBisson triaged this task as High priority.
SBisson added a project: Inuka-Team (Kanban).
SBisson moved this task from Backlog to Dev on the Inuka-Team (Kanban) board.

Change 909259 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] RC: Handle deleted story

https://gerrit.wikimedia.org/r/909259

Change 909259 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] RC: Handle deleted story

https://gerrit.wikimedia.org/r/909259

Change 909276 had a related patch set uploaded (by Zabe; author: Sbisson):

[mediawiki/extensions/Wikistories@wmf/1.41.0-wmf.4] RC: Handle deleted story

https://gerrit.wikimedia.org/r/909276

Change 909276 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@wmf/1.41.0-wmf.4] RC: Handle deleted story

https://gerrit.wikimedia.org/r/909276

Mentioned in SAL (#wikimedia-operations) [2023-04-17T21:38:03Z] <zabe@deploy2002> Started scap: Backport for [[gerrit:909276|RC: Handle deleted story (T334829)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-17T21:39:17Z] <zabe@deploy2002> zabe: Backport for [[gerrit:909276|RC: Handle deleted story (T334829)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-17T21:45:05Z] <zabe@deploy2002> Finished scap: Backport for [[gerrit:909276|RC: Handle deleted story (T334829)]] (duration: 07m 01s)

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.

Deployed and verified in production