Page MenuHomePhabricator
Create Task
Maniphest T334857

StopForumSpam should return true within onGetUserPermissionsErrorsExpensive for the report-only + ip-denylisted case
Closed, ResolvedPublic
Actions

Description

There should be a return true; somewhere around here within Hooks.php. Otherwise the action ends up being "blocked" and erroneously logged in report-only mode, which we do not want given current expectations.

Details

SubjectRepoBranchLines +/-
Add additional conditional to account for report-only + non-denylisted IP casemediawiki/extensions/StopForumSpammaster+4 -0
Add missing return to onGetUserPermissionsErrorsExpensive hook conditional blockmediawiki/extensions/StopForumSpammaster+2 -0
Customize query in gerrit

Event Timeline

sbassett created this task.Apr 17 2023, 2:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2023, 2:18 PM
sbassett changed the task status from Open to In Progress.Apr 17 2023, 2:18 PM
sbassett triaged this task as Medium priority.
sbassett moved this task from Backlog to In Progress on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from Incoming to In Progress on the Security-Team board.
sbassett moved this task from Backlog to In Progress on the user-sbassett board.
gerritbot added a comment.Apr 17 2023, 2:21 PM

Change 908878 had a related patch set uploaded (by SBassett; author: SBassett):

[mediawiki/extensions/StopForumSpam@master] Add missing return to onGetUserPermissionsErrorsExpensive hook conditional block

https://gerrit.wikimedia.org/r/908878

gerritbot added a project: Patch-For-Review.Apr 17 2023, 2:21 PM
sbassett updated the task description. (Show Details)Apr 17 2023, 3:16 PM
sbassett updated the task description. (Show Details)
gerritbot added a comment.Apr 17 2023, 3:25 PM

Change 908878 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] Add missing return to onGetUserPermissionsErrorsExpensive hook conditional block

https://gerrit.wikimedia.org/r/908878

gerritbot added a comment.Apr 17 2023, 3:30 PM

Change 908880 had a related patch set uploaded (by SBassett; author: SBassett):

[mediawiki/extensions/StopForumSpam@master] Add additional condtional to account for report-only + non-denylisted IP case

https://gerrit.wikimedia.org/r/908880

gerritbot added a comment.Apr 17 2023, 7:08 PM

Change 908880 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] Add additional conditional to account for report-only + non-denylisted IP case

https://gerrit.wikimedia.org/r/908880

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 7:11 PM
sbassett closed this task as Resolved.Apr 24 2023, 11:28 PM
sbassett moved this task from In Progress to Done on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from In Progress to Our Part Is Done on the Security-Team board.
sbassett moved this task from In Progress to Done on the user-sbassett board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL