Page MenuHomePhabricator

License picker on Special:Upload defaults to last section header
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The selected entry on the license picker is "Other Alternatives:". The "None selected" message is also marked as selected in the HTML, but because the last section header comes later, it is used by the browser.

What should have happened instead?:
The "None selected" message should be the only selected entry.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Not a Commons-specific problem, also happens on https://en.wikipedia.org/wiki/Special:Upload

Event Timeline

Same issue on fr.wikipedia.org:

I think it's safe to say that it affects all wikis.

Change 985361 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985361

Change 985361 merged by jenkins-bot:

[mediawiki/core@master] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985361

Change 985043 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/core@REL1_41] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985043

Change 985044 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/core@REL1_40] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985044

Change 985045 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/core@REL1_39] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985045

Do we know when this broke? Or has it always been?

Just trying to work out if I merge the (trivial) backports...

Early this year is my best guess. My memory is hazy, but I think I noticed it in March before I decided to report in April.

Change 985043 merged by jenkins-bot:

[mediawiki/core@REL1_41] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985043

Change 985045 merged by jenkins-bot:

[mediawiki/core@REL1_39] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985045

Change 985044 merged by jenkins-bot:

[mediawiki/core@REL1_40] Headings in the license pickers should not be selected

https://gerrit.wikimedia.org/r/985044

TheDJ claimed this task.