Maniphest T335035

In dark theme, edit preview HTML doesn't get dark theme applied to it.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dbrant
	Apr 19 2023, 1:16 PM

Tags

Referenced Files

	F36959602: Screenshot_2023-04-21-21-30-40-51_2c49f68a4a6b3359d2a6bd122cb3bac6.jpg
	Apr 21 2023, 6:31 PM

	F36956510: Screenshot_20230419_091540.png
	Apr 19 2023, 1:16 PM

Subscribers

Description

We don't seem to be correctly applying the theme setup logic to the preview HTML when we display it:

Screenshot_20230419_091540.png (2×1 px, 298 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix setting of background color for Android dark/black themes.	mediawiki/services/mobileapps	master	+4 -4

Customize query in gerrit

Event Timeline

Dbrant created this task.Apr 19 2023, 1:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2023, 1:16 PM

Dbrant triaged this task as Medium priority.Apr 19 2023, 1:16 PM

Dbrant moved this task from Needs Triage to Android Release - FY2023-24 on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android Release - FY2023-24); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from Epics in Progress to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.

Change 910034 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/services/mobileapps@master] Fix setting of background color for Android dark/black themes.

https://gerrit.wikimedia.org/r/910034

gerritbot added a project: Patch-For-Review.Apr 19 2023, 3:33 PM

Dbrant claimed this task.Apr 19 2023, 4:07 PM

Dbrant moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Apr 19 2023, 5:52 PM

Appears to be fixed on 2.7.50440-r-2023-04-19

Screenshot_2023-04-21-21-30-40-51_2c49f68a4a6b3359d2a6bd122cb3bac6.jpg (2×1 px, 720 KB)

Change 910034 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Fix setting of background color for Android dark/black themes.

https://gerrit.wikimedia.org/r/910034

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2023, 3:29 PM

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.May 3 2023, 4:43 PM

Dbrant closed this task as Resolved.May 5 2023, 1:09 PM