Page MenuHomePhabricator
Create Task
Maniphest T335134

Fix article migration loop
Closed, ResolvedPublic
Actions

Description

Discovered from https://phabricator.wikimedia.org/T334759#8794589

We had a user log that is stuck in a migrateMobileviewToMobileHTMLIfNecessary loop. They have a WMFArticle database object that indicates an article needs migration, but there is no legacy article data for it to migrate. We should delete the WMFArticle object in this case. Fixing this could improve performance.

Time to fix: 1 day

Related Objects

Event Timeline

Tsevener created this task.Apr 20 2023, 1:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2023, 1:08 PM
Tsevener updated the task description. (Show Details)Apr 20 2023, 1:09 PM
Tsevener mentioned this in T334759: [SPIKE] Investigate performance issues in app.Apr 20 2023, 2:34 PM
JTannerWMF triaged this task as High priority.Apr 25 2023, 8:52 PM
JTannerWMF added a project: iOS Release FY2023-24 (Archive).
JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
JTannerWMF moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.
Tsevener claimed this task.Apr 25 2023, 10:14 PM
Tsevener added a comment.Apr 25 2023, 10:41 PM

https://github.com/wikimedia/wikipedia-ios/pull/4515

Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Apr 25 2023, 10:42 PM
Tsevener added a comment.Apr 28 2023, 9:44 PM

Fix is in TestFlight 7.2.2 (2178)

Tsevener added a comment.EditedApr 28 2023, 9:50 PM

T335077 will test this one as well, so moving to ready for release. Will close once this is released.

Tsevener moved this task from Needs Code Review to Ready for Release on the iOS Release FY2023-24 (Archive) board.Apr 28 2023, 9:50 PM
Tsevener mentioned this in T335905: Release 7.2.2 .May 3 2023, 7:28 PM
Mazevedo closed this task as Resolved.May 10 2023, 5:57 PM
Mazevedo removed Tsevener as the assignee of this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL