Page MenuHomePhabricator

Valid caption "thumb" in italics falsely detected as Linter bogus image option
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Create a page with the following content:

[[File:Thumbup.jpg|thumb|50px|''thumb'']]

What happens?:
Linter reports "thumb" as a bogus image option.

What should have happened instead?:
"thumb" in italics should be allowed as a valid image caption. No Linter error should be detected.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This was reported in https://phabricator.wikimedia.org/T179605#4956758 but it should have been opened as a separate bug.

Event Timeline

Change 912992 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Fail to stringify if quote found in non-wikitext option

https://gerrit.wikimedia.org/r/912992

Related: valid caption "thumb" in a gallery is falsely detected as an error:

https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1154142412

Once again, we probably need a "caption=" option to force a caption for images to work around these edge cases.

Arlolra triaged this task as Medium priority.
Arlolra added a project: Parsoid.
Arlolra moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

Change 912992 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fail to stringify if quote found in non-wikitext media option

https://gerrit.wikimedia.org/r/912992

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706