Page MenuHomePhabricator

LintError bogus-image-options triggers on "Thumbtime"
Open, MediumPublic

Description

See example here. Both "thumbtime" and "Thumbtime" work correctly, but a lint error is flagged for "Thumbtime". Additionally, mw:Help:Extension:Linter/bogus-image-options refers to mw:Help:Images but nothing is mentioned there about case-sensitivity.

Event Timeline

Bdijkstra created this task.Nov 2 2017, 6:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2017, 6:40 PM
Bdijkstra updated the task description. (Show Details)Nov 2 2017, 6:41 PM
Arlolra claimed this task.Nov 2 2017, 10:47 PM
Arlolra triaged this task as Medium priority.
Arlolra added a project: Parsoid.
Arlolra added a subscriber: Arlolra.

It seems the img_ options are "case-sensitive" but the timedmedia_ are not.

ssastry added a subscriber: ssastry.Nov 3 2017, 4:45 PM

It seems the img_ options are "case-sensitive" but the timedmedia_ are not.

That seems broken ... it seems everything should be one way or the other. Is there any reason not to fix that problem instead? But, of course, the qn. is how much pages will be affected by that change -- we have the means to assess that via linter by creating a separate deprecations category maybe?

In case it isn't clear, these are marked case-sensitive in the per wiki configs. I haven't verified that that's the case for all of them, merely for enwiki.

ssastry moved this task from Needs Triage to Linting on the Parsoid board.Nov 6 2017, 4:23 PM

Perhaps related?

https://nl.wikipedia.org/w/index.php?title=Mariano_Cordovani&action=edit&lintid=1535825

It triggered on "Miniatuur". A local alias of "thumb" is "miniatuur" (lower case).

Reedy edited projects, added Parsoid-Linter; removed Parsoid.Sep 17 2018, 7:27 PM
Arlolra removed Arlolra as the assignee of this task.Jan 25 2019, 5:20 PM

Another false positive:

[[File:Thumbup.jpg|thumb|50px|''thumb'']]

This may be related to T216566.

Aklapper edited projects, added Parsoid; removed Parsoid-Linter.Feb 29 2020, 5:13 PM