Page MenuHomePhabricator

Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options.
Open, MediumPublic

Description

Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options.

Here are some test cases that show the problem on en.WP:

[[Image:Milgrom Mordechai.jpg|Thumb|upright|link=foo| MOND was proposed by Mordehai Milgrom in 1983]]

[[Image:Milgrom Mordechai.jpg|Frame|upright|link=foo| MOND was proposed by Mordehai Milgrom in 1983]]

[[Image:Milgrom Mordechai.jpg|Border|thumb|upright|link=foo| MOND was proposed by Mordehai Milgrom in 1983]]

[[Image:Milgrom Mordechai.jpg|border|thumb|upright|link=foo| MOND was proposed by Mordehai Milgrom in 1983]]

[[Image:Milgrom Mordechai.jpg|Frameless|upright|link=foo| MOND was proposed by Mordehai Milgrom in 1983]]

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2019, 10:03 PM

This one is actually flagged as an error on en.WP:

[[Image:(1919) pic37 - Siameses in France.jpg|thumb|ALT=Old newspaper clipping of Asian soldiers|Siamese in France]]

The inconsistency is baffling. Maybe options with equals signs are correctly flagged as errors, while options without are ignored but not flagged?

This is still happening. There has been no action on this bug report in over a year, not even triage, apparently. Bogus File Options are listed as a "medium priority" Linter error, FWIW. Please let us volunteers know how we can help.

ssastry added a subscriber: ssastry.

Sorry, all of last year, we were neck deep in porting Parsoid from JS to PHP and we had to necessarily ignore most of everything else. But, thanks for the ping here. I've tagged Parsoid on this so we can triage this and see if there is a quick fix (likely, but cannot confirm without looking more closely).

ssastry triaged this task as Medium priority.Feb 21 2020, 5:08 PM
ssastry moved this task from Needs Triage to Backlog on the Parsoid board.

Thanks for the attention, and let me know if I can help with troubleshooting.

Note: also see T216003 and T215999 for other apparent Linter bugs related to bogus file options. There appear to be some underlying bugs with the way that image options are processed/interpreted.

ssastry moved this task from Backlog to Linting on the Parsoid board.Feb 29 2020, 6:05 PM
NicoV added a subscriber: NicoV.Sat, Oct 3, 7:13 AM