Right" as caption for gallery image
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jonesey95
	Oct 25 2020, 2:53 PM

Description

See https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=985362785

The words "Center", "Left", or "Right" used as a caption for a gallery image work fine but are detected as a Linter error.

https://www.mediawiki.org/wiki/Help:Images#Rendering_a_gallery_of_images does not contain a workaround like "caption=" or "1=" for gallery image captions.

This is actually a Parsoid/Gallery bug which consumes the captions if they are the words left, center or right and treats them as halign values that are invalid, and also causes erroneous linter errors. See:
https://phabricator.wikimedia.org/T275074
for further details

Details

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.14.0-a17	mediawiki/vendor	master	+207 -190
	Make magic words case-sensitive	mediawiki/services/parsoid	master	+38 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T266406 Linter false positive: "Center/Left/Right" as caption for gallery image
		Open		None	T275074 Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image

Event Timeline

Jonesey95 created this task.Oct 25 2020, 2:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2020, 2:53 PM

ssastry moved this task from Needs Triage to Linting on the Parsoid board.Oct 27 2020, 3:54 PM

Jonesey95 mentioned this in T216566: Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options..Jan 22 2021, 12:32 AM

Sbailey claimed this task.Feb 4 2021, 9:22 PM

Jonesey95 mentioned this in T274382: Make File syntax processing match the specification and documentation.Feb 10 2021, 3:35 PM

Notes: If looks like the use of left, right or center as caption words not only generates linter errors, the captions are not there, as the words have been eaten as options and not allowed to be captions. In looking at this further, the use of left, right or center in gallary seems not to be valid as an option, and so should be allowed as captions. In the following example,

<gallery>
File:Foobar.jpg|left
File:Foobar.jpg|notaleft
</gallery>

produces linter error:

{"type":"bogus-image-options","dsr":[0,66,9,10],"params":{"items":["left"]}}

and renders as:

... class="gallerytext" data-parsoid="{}"></div></li>
... class="gallerytext" data-parsoid='{"dsr":[47,55,0,0]}'>notaleft</div></li>

ssastry mentioned this in T275074: Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image.Feb 17 2021, 9:36 PM

Sbailey updated the task description. (Show Details)Feb 18 2021, 8:37 PM

Sbailey removed Sbailey as the assignee of this task.Feb 18 2021, 8:40 PM

Sbailey subscribed.

Arlolra added a subtask: T275074: Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image.Feb 24 2021, 5:42 PM

I'm not sure if this is the same bug or a different bug, but I just came across something similar with "Frame". This syntax on en.WP renders correctly (the word "Frame" appears as a caption) but generates a Linter false positive error:

[[File:Frame front 30.jpg|right|thumb|100px|Frame]]

Once again, the lack of a caption= option to override this quirk is a problem. I hope that someone is willing to take the time to gather all of these File syntax tasks and sort out ticket T274382.

Change 714145 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Make magic words case-sensitive

https://gerrit.wikimedia.org/r/714145

gerritbot added a project: Patch-For-Review.Aug 23 2021, 8:08 PM

Change 714145 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Make magic words case-sensitive

https://gerrit.wikimedia.org/r/714145

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2021, 4:10 AM