Linter does not detect invalid "500px500px" as a bogus file option
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jonesey95
	Feb 13 2019, 8:05 AM

Description

See https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox3&oldid=883099293

I came across this invalid sizing option in the wild: (number)px(number)px. Valid options are:

*(number)x(number)px
*(number)px
*x(number)px

The file specification in question has an unnamed caption parameter, which is interpreted correctly, so it looks like the "px" parameter is being read as a sizing parameter, but it is invalid and is not processed. If I change it to "500p", it is correctly flagged by Linter as extra text.

"500px500px" should be flagged as a Bogus file option by Linter.

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.13.0-a25	mediawiki/vendor	master	+755 -237
Lint duplicated media width options	mediawiki/services/parsoid	master	+26 -4
Lint bogus media width options	mediawiki/services/parsoid	master	+15 -0

Customize query in gerrit

Related Objects

Mentioned In: T276675: Linter false positive: image caption ending in "px" is incorrectly detected as a Linter error
T274382: Make File syntax processing match the specification and documentation
T207032: Lint away 'pxpx'
T216566: Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options.

Event Timeline

Jonesey95 created this task.Feb 13 2019, 8:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2019, 8:05 AM

See also the second example here:

https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox3&oldid=883109306

It contains "600 px" as a setting. It is similarly invalid, not processed, and not marked as bogus.

(Edited to add: I have updated Help:Images on the MediaWiki site to document this behavior. If it is a feature, then you can ignore this second example, since it is documented now. If it's a bug, let me know here, and I'll correct the documentation. Thanks.)

Legoktm added a project: Parsoid-Linter.Feb 13 2019, 6:00 PM

Possibly related: "left150px" is not recognized as a bogus option.

[File:Israeli Ballot Divider.JPG|thumb|left150px|Israeli poll booth]

It does not resize to 150px, it does not place the image on the left, and it does not show a Linter error. At least one of those behaviors appears to be a bug.

ssastry triaged this task as Medium priority.Mar 11 2019, 5:08 PM

ssastry moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

Jonesey95 mentioned this in T216566: Capitalized versions of valid File options are usually ignored, but are not flagged as Linter bogus file options..Feb 21 2020, 5:30 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Linter.Feb 29 2020, 5:13 PM

ssastry moved this task from Needs Triage to Linting on the Parsoid board.Feb 29 2020, 6:04 PM

Another flavor that is not detected as a Linter error (extra "300px" parameter):

[[File:Standard of Macdonald of Clanranald.svg|thumb|300px|300px|[[Heraldic standard]] of the current clan chief.]]

Similar:

NicoV subscribed.Oct 3 2020, 7:14 AM

• Sbailey claimed this task.Jan 27 2021, 6:43 PM

• Sbailey mentioned this in T207032: Lint away 'pxpx'.Feb 4 2021, 9:15 PM

Change 661820 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP Catch invalid image link parameters

https://gerrit.wikimedia.org/r/661820

gerritbot added a project: Patch-For-Review.Feb 4 2021, 11:21 PM

Jonesey95 mentioned this in T274382: Make File syntax processing match the specification and documentation.Feb 10 2021, 3:35 PM

Change 665226 had a related patch set uploaded (by Arlolra; owner: Sbailey):
[mediawiki/services/parsoid@master] Lint duplicated media width options

https://gerrit.wikimedia.org/r/665226

Change 661820 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Lint bogus media width options

https://gerrit.wikimedia.org/r/661820

Change 665226 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Lint duplicated media width options

https://gerrit.wikimedia.org/r/665226

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2021, 1:12 AM

Fixed by patches:

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/661820

which addresses bogus width options, and

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/665226

which addresses duplicate width options.

Change 666213 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a25

https://gerrit.wikimedia.org/r/666213

gerritbot added a project: Patch-For-Review.Feb 22 2021, 9:50 PM

Change 666213 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a25

https://gerrit.wikimedia.org/r/666213

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2021, 11:11 PM

Jonesey95 mentioned this in T276675: Linter false positive: image caption ending in "px" is incorrectly detected as a Linter error.Mar 6 2021, 5:23 PM