Maniphest T207032

Lint away 'pxpx'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Oct 15 2018, 1:53 PM

Description

For backwards-compatibility reasons, we allow "pxpx" as well as "px" when we parse image size options.

We should lint this away.

See T15500: Improper scaling of images sized with "pxpx", T53628: Images specified with size foopxpx render at native size (and parser test cases mentioning these phab tasks).

Details

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.17.0-a10	mediawiki/vendor	master	+288 -112
	Lint away 'pxpx'	mediawiki/services/parsoid	master	+34 -5

Customize query in gerrit

Related Objects

Mentioned In: T53628: Images specified with size foopxpx render at native size
Mentioned Here: T215999: Linter does not detect invalid "500px500px" as a bogus file option
T15500: Improper scaling of images sized with "pxpx"
T53628: Images specified with size foopxpx render at native size

Event Timeline

cscott created this task.Oct 15 2018, 1:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 1:53 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Linter.Feb 29 2020, 5:13 PM

ssastry moved this task from Needs Triage to Linting on the Parsoid board.Feb 29 2020, 6:04 PM

ssastry triaged this task as Medium priority.Mar 8 2020, 1:00 AM

This appears to be related to T215999
Linter does not detect invalid "500px500px" as a bogus file option

Jonesey95 subscribed.Feb 5 2021, 1:07 AM

• Sbailey removed • Sbailey as the assignee of this task.Mar 1 2022, 8:11 PM

Change 867300 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Lint away 'pxpx'

https://gerrit.wikimedia.org/r/867300

gerritbot added a project: Patch-For-Review.Dec 13 2022, 1:12 AM

Arlolra claimed this task.Dec 13 2022, 1:12 AM

Arlolra added a project: Content-Transform-Team-WIP.

Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

@Jonesey95 I put this question in the commit message. Maybe you have an opinion?

Question: Is bogus file options the correct category for this
considering that these options are accepted, they just have backwards
compatibility support we'd like to remove?`

Yes, bogus file options is the correct category for this. Thanks. Fixing Lint is (almost) all about removing backwards compatibility for hacks and workarounds and errors that are no longer accepted.

Change 867300 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Lint away 'pxpx'

https://gerrit.wikimedia.org/r/867300

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Dec 13 2022, 11:59 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 12:32 AM

Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Jan 9 2023, 4:06 PM

Change 877256 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10

https://gerrit.wikimedia.org/r/877256

gerritbot added a project: Patch-For-Review.Jan 9 2023, 8:43 PM

Change 877256 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10