Page MenuHomePhabricator
Create Task
Maniphest T336073

Wikitext paste converter not shown on mobile
Closed, ResolvedPublic
Actions

Description

  1. Open DT's reply tool or new topic tool, which use the 2017 WTE on mobile.
  2. Switch to source mode
  3. Paste some rich text (e.g. html with links or lists)
  1. Observed: pastes plain with no prompt

image.png (661×417 px, 54 KB)

  1. Expected: the "convert to wikitext" prompt is show, as on desktop:

image.png (644×412 px, 56 KB)

Details

SubjectRepoBranchLines +/-
MWWikitextSurface: Deactivate surface on mobile before showing paste contextmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Event Timeline

Esanders created this task.May 5 2023, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2023, 4:56 PM
Esanders added a comment.May 5 2023, 4:56 PM

The mobile context checks to see if the virtual keyboard is visible before showing a context, so we need to suppress the virtual keyboard manually.

gerritbot added a comment.May 5 2023, 4:57 PM

Change 916529 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] MWWikitextSurface: Deactivate surface on mobile before showing paste context

https://gerrit.wikimedia.org/r/916529

gerritbot added a project: Patch-For-Review.May 5 2023, 4:57 PM
matmarex added a project: Editing-team (Kanban Board).May 10 2023, 12:52 AM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.May 10 2023, 1:09 AM

Change 916529 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWWikitextSurface: Deactivate surface on mobile before showing paste context

https://gerrit.wikimedia.org/r/916529

Maintenance_bot removed a project: Patch-For-Review.May 10 2023, 1:10 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 10 2023, 1:42 AM
matmarex added a project: Editing QA.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 10 2023, 4:15 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 5:02 PM
matmarex closed this task as Resolved.May 17 2023, 4:11 PM
matmarex assigned this task to Esanders.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL