Phpunit tests of Kartographer fails when running with Dashiki extensions (SimpleStyleParserTest)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 15 2023, 9:57 PM

Description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Dashiki/+/916891

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/100807/console

1) Kartographer\Tests\SimpleStyleParserTest::testNormalizeAndSanitize with data set #9 ('{\n					"type": "ExternalData...n				}', '{\n					"type": "ExternalData...n				}')
Failed asserting that false is identical to true.

/workspace/src/extensions/Kartographer/tests/phpunit/SimpleStyleParserTest.php:132
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:522
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"HashBagOStuff"}
===

Details

	Subject	Repo	Branch	Lines +/-
	tests: Force init for JCSingleton after config change	mediawiki/extensions/Kartographer	master	+2 -0
	tests: Allow forced init for JCSingleton after config change	mediawiki/extensions/JsonConfig	master	+6 -2

Customize query in gerrit

Event Timeline

Umherirrender created this task.May 15 2023, 9:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2023, 9:57 PM

Umherirrender unsubscribed.Jul 12 2023, 8:01 PM

I tried to figure out what's going on here but had to give up. Locally I don't see an issue.

One thing I noticed is that both extensions depend on the JsonConfig extension and somehow use it as a vehicle. Kartographer does have a page service that loads GeoJSON from a JSON page in a Data: namespace. (That's exactly the test that fails.) Dashiki is supposed to render JSON pages in human-readable HTML. But that should only influence how a page looks, not how APIs behave.

Dashiki doesn't have any tests.

Change 982158 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Kartographer@master] tests: Reset title parser from JCSingleton in SimpleStyleParserTest

https://gerrit.wikimedia.org/r/982158

gerritbot added a project: Patch-For-Review.Dec 11 2023, 8:46 PM

Change 982158 abandoned by Umherirrender:

[mediawiki/extensions/Kartographer@master] tests: Reset title parser from JCSingleton in SimpleStyleParserTest

Reason:

Cannot reset static $isInitialized in JCSingleton::init() as it is function locally and not a property or such.

It seems JCSingleton must be converted to service to benefit from changes of global config

https://gerrit.wikimedia.org/r/982158

Umherirrender removed a project: Patch-For-Review.Dec 11 2023, 9:32 PM

Change 982158 restored by Umherirrender:

[mediawiki/extensions/Kartographer@master] tests: Reset title parser from JCSingleton in SimpleStyleParserTest

https://gerrit.wikimedia.org/r/982158

gerritbot added a project: Patch-For-Review.Dec 16 2023, 7:27 PM

Change 983523 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/JsonConfig@master] tests: Allow forced init for JCSingleton after config change

https://gerrit.wikimedia.org/r/983523

Change 983523 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] tests: Allow forced init for JCSingleton after config change

https://gerrit.wikimedia.org/r/983523

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 17 2023, 1:00 AM

Change 982158 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] tests: Force init for JCSingleton after config change

https://gerrit.wikimedia.org/r/982158

Umherirrender closed this task as Resolved.Dec 17 2023, 2:46 PM

Umherirrender claimed this task.

Umherirrender removed a project: Patch-For-Review.

Phpunit tests of Kartographer fails when running with Dashiki extensions (SimpleStyleParserTest)Closed, ResolvedPublicActions

Description

Details

Event Timeline

Phpunit tests of Kartographer fails when running with Dashiki extensions (SimpleStyleParserTest)
Closed, ResolvedPublic
Actions