Page MenuHomePhabricator
Create Task
Maniphest T337030

MMV should use packageFiles and not expose globals
Closed, ResolvedPublic
Actions

Description

MMV currently exposes all its methods on the mw.mmv object. This makes the code harder to follow and is not inline with current coding standards.

On the long term this work should make it easier to reduce the number of modules in the extension.

TODO

  • Switch mmv
  • Switch mmv.ui.ondemandshareddependencies
  • switch mmv.ui.download.pane
  • Switch mmv.ui.reuse.shareembed
  • Switch mmv.bootstrap
  • Switch mmv.bootstrap.autostart
  • Switch mmv.head

Here is an example in PageTriage: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/917967

Screenshot 2023-05-21 at 14-11-59 Screenshot.png (1×3 px, 701 KB)

Details

SubjectRepoBranchLines +/-
Remove global mw.mmvmediawiki/extensions/MultimediaViewermaster+0 -63
Use packageFiles in mmv.testmediawiki/extensions/MultimediaViewermaster+627 -385
Use packageFiles in mmvmediawiki/extensions/MultimediaViewermaster+126 -119
Use packageFiles in mmvmediawiki/extensions/MultimediaViewermaster+459 -249
Use packageFiles in mmv.bootstrapmediawiki/extensions/MultimediaViewermaster+19 -9
Use packageFiles in mmv.ui.ondemandshareddependenciesmediawiki/extensions/MultimediaViewermaster+28 -3
Use packageFiles in mmv.ui.reuse.shareembedmediawiki/extensions/MultimediaViewermaster+46 -15
Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 19 2023, 1:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2023, 1:02 PM
Jdlrobson added a subscriber: simon04.May 19 2023, 1:02 PM
simon04 claimed this task.May 19 2023, 1:54 PM
simon04 added a project: Wikimania-Hackathon-2023.
gerritbot added a comment.May 19 2023, 2:34 PM

Change 921365 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.bootstrap

https://gerrit.wikimedia.org/r/921365

gerritbot added a project: Patch-For-Review.May 19 2023, 2:34 PM
gerritbot added a comment.May 19 2023, 2:50 PM

Change 921370 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.ui.ondemandshareddependencies

https://gerrit.wikimedia.org/r/921370

gerritbot added a comment.May 19 2023, 3:06 PM

Change 921377 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.ui.reuse.shareembed

https://gerrit.wikimedia.org/r/921377

gerritbot added a comment.May 19 2023, 4:45 PM

Change 921377 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.ui.reuse.shareembed

https://gerrit.wikimedia.org/r/921377

gerritbot added a comment.May 19 2023, 4:45 PM

Change 921370 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.ui.ondemandshareddependencies

https://gerrit.wikimedia.org/r/921370

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 19 2023, 5:00 PM
gerritbot added a comment.May 19 2023, 6:52 PM

Change 921411 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv

https://gerrit.wikimedia.org/r/921411

gerritbot added a comment.May 19 2023, 8:28 PM

Change 921365 abandoned by Simon04:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.bootstrap

Reason:

Integrated into I90cdfb626c176b27b59db6b92b9edd6b2fe49b68

https://gerrit.wikimedia.org/r/921365

gerritbot added a comment.May 20 2023, 6:40 AM

Change 921411 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv

https://gerrit.wikimedia.org/r/921411

gerritbot added a comment.May 20 2023, 7:05 AM

Change 921435 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv

https://gerrit.wikimedia.org/r/921435

gerritbot added a comment.May 20 2023, 8:25 AM

Change 921435 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv

https://gerrit.wikimedia.org/r/921435

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 8:30 AM
gerritbot added a comment.May 20 2023, 8:34 AM

Change 921441 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.test

https://gerrit.wikimedia.org/r/921441

gerritbot added a project: Patch-For-Review.May 20 2023, 8:34 AM

Change 921442 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Remove global mw.mmv

https://gerrit.wikimedia.org/r/921442

gerritbot added a comment.May 21 2023, 8:14 AM

Change 921441 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use packageFiles in mmv.test

https://gerrit.wikimedia.org/r/921441

gerritbot added a comment.May 21 2023, 8:25 AM

Change 921442 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Remove global mw.mmv

https://gerrit.wikimedia.org/r/921442

Maintenance_bot removed a project: Patch-For-Review.May 21 2023, 8:30 AM
simon04 closed this task as Resolved.May 21 2023, 9:12 AM
simon04 updated the task description. (Show Details)
simon04 updated the task description. (Show Details)May 21 2023, 11:12 AM
Jdforrester-WMF awarded a token.May 21 2023, 11:19 AM
Jdlrobson added a comment.May 21 2023, 11:56 AM

🥳

TheDJ edited projects, added Wikimedia-Hackathon-2023; removed Wikimania-Hackathon-2023.Jun 7 2023, 2:51 PM
TheDJ moved this task from Backlog to Hacking projects on the Wikimedia-Hackathon-2023 board.Jun 7 2023, 2:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL