Page MenuHomePhabricator

Make PHPUnit dataProvider static in AbuseFilter tests
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • SchemaChangesHandlerTest with provideAbuseFilterUser
  • AbuseFilterPermissionManagerTest with provideCanEdit, provideCanEditFilter, provideCanViewProtectedVariablesInFilter
  • BlockAutopromoteStoreTest with provideBlockAutopromote, provideUnblockAutopromote
  • BlockTest with provideRevert
  • ChangeTaggerTest with provideActionData
  • ThrottleTest with provideThrottle, provideThrottleDataForIdentifiers
  • WarnTest with provideWarnsAndSuccess
  • FilterValidatorTest with provideSyntax, provideRestrictedActions, provideCheckAll
  • ParserStatusTest with provideIsValid
  • ParserTest with provideDeprecatedVars
  • VariableGeneratorTest with provideTitleVarsNotLazy
  • LazyVariableComputerTest with provideUserRelatedVars, provideTitleRelatedVars
  • VariablesManagerTest with provideDumpAllVars, provideGetVar

static and adjust the usages (More infos at T332865).

Initial work was done in faaa5126eb8ae878220c78adbeb69cc66e3137f2

Event Timeline

Change 930638 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] Make some non-static providers static

https://gerrit.wikimedia.org/r/930638

Change 930638 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Make some non-static providers static

https://gerrit.wikimedia.org/r/930638

Change #1139160 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/AbuseFilter@master] phpunit: Make data providers static in FilterValidatorTest

https://gerrit.wikimedia.org/r/1139160

Change #1139160 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] phpunit: Make data providers static in FilterValidatorTest

https://gerrit.wikimedia.org/r/1139160

Change #1140278 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] tests: Make some PHPUnit data providers static

https://gerrit.wikimedia.org/r/1140278

Change #1140278 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140278

Change #1141558 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Enable PHPCS rule for PHPUnit data provider names, make one static

https://gerrit.wikimedia.org/r/1141558

Change #1141558 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Enable PHPCS rule for PHPUnit data provider names, make one static

https://gerrit.wikimedia.org/r/1141558

Change #1143887 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1143887

Change #1143887 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1143887

Umherirrender updated the task description. (Show Details)

Change #1147121 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static in ConsequenceGetMessageTest

https://gerrit.wikimedia.org/r/1147121

Change #1147121 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static in ConsequenceGetMessageTest

https://gerrit.wikimedia.org/r/1147121