Page MenuHomePhabricator
Create Task
Maniphest T337166

Make PHPUnit dataProvider static in CampaignEvents tests
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be used on static functions only, for PHPUnit 10 compatibility (see T332865). Find non-static data providers and make them static. See codesearch.

Initial work was done in 4d745381debfe28cbea15e67be50534624e675be

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: Use callable types for provideBadTokenSessions data providermediawiki/extensions/WikimediaCampaignEventsmaster+4 -8
tests: Allow callable from provideBadTokenSessions data providermediawiki/extensions/WikimediaCampaignEventsmaster+8 -4
tests: Make PHPUnit data provider staticmediawiki/extensions/CampaignEventsmaster+256 -211
tests: Make PHPUnit data provider staticmediawiki/extensions/CampaignEventsmaster+2 -2
Replace more non-static data providersmediawiki/extensions/CampaignEventsmaster+266 -350
tests: Avoid non-static data providersmediawiki/extensions/CampaignEventsmaster+687 -796
phpunit: make data providers static in more testsmediawiki/extensions/CampaignEventsmaster+254 -233
tests: Make some PHPUnit data providers staticmediawiki/extensions/CampaignEventsmaster+114 -147
tests: Make remaining data providers static in PermissionCheckerTestmediawiki/extensions/CampaignEventsmaster+131 -125
tests: Make data providers static in PermissionCheckerTest, part 1mediawiki/extensions/CampaignEventsmaster+232 -152
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 20 2023, 11:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2023, 11:49 PM
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 11:49 PM
Umherirrender updated the task description. (Show Details)May 30 2023, 7:30 PM
Umherirrender unsubscribed.Jul 12 2023, 8:42 PM
Daimona moved this task from Backlog to Tech debt on the CampaignEvents board.Nov 10 2023, 6:02 PM
gerritbot added a comment.Jun 26 2024, 10:28 PM

Change #1050067 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Make data providers static in PermissionCheckerTest, part 1

https://gerrit.wikimedia.org/r/1050067

gerritbot added a project: Patch-For-Review.Jun 26 2024, 10:28 PM

Change #1050073 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Make remaining data providers static in PermissionCheckerTest

https://gerrit.wikimedia.org/r/1050073

gerritbot added a comment.Jun 28 2024, 9:10 PM

Change #1050067 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make data providers static in PermissionCheckerTest, part 1

https://gerrit.wikimedia.org/r/1050067

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 28 2024, 10:00 PM
gerritbot added a comment.Jun 28 2024, 10:15 PM

Change #1050073 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make remaining data providers static in PermissionCheckerTest

https://gerrit.wikimedia.org/r/1050073

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2024, 10:30 PM
Pppery subscribed.Nov 1 2024, 6:35 PM

Anything left to do here?

Daimona subscribed.Nov 1 2024, 6:52 PM
In T337166#10285156, @Pppery wrote:

Anything left to do here?

Yeah, a lot unfortunately...

Pppery unsubscribed.Nov 1 2024, 6:53 PM
Daimona claimed this task.Jan 8 2025, 12:31 PM
Daimona added a project: Connection-Team (Connection-Current-Sprint).
Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Jan 8 2025, 12:50 PM
gerritbot added a comment.Jan 8 2025, 1:40 PM

Change #1109067 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Make some PHPUnit data providers static

https://gerrit.wikimedia.org/r/1109067

gerritbot added a project: Patch-For-Review.Jan 8 2025, 1:40 PM
gerritbot added a comment.Jan 9 2025, 11:05 PM

Change #1109504 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] phpunit: make data providers static in more tests

https://gerrit.wikimedia.org/r/1109504

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jan 10 2025, 7:07 PM
gerritbot added a comment.Jan 17 2025, 6:07 PM

Change #1109067 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make some PHPUnit data providers static

https://gerrit.wikimedia.org/r/1109067

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 17 2025, 7:00 PM
gerritbot added a comment.Jan 20 2025, 11:11 AM

Change #1109504 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] phpunit: make data providers static in more tests

https://gerrit.wikimedia.org/r/1109504

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2025, 11:30 AM
Daimona removed Daimona as the assignee of this task.Jan 20 2025, 1:24 PM
Daimona edited projects, added Connection-Team; removed Connection-Team (Connection-Current-Sprint).

Fixed a few tests, but still a lot to go. Unassigning myself and removing from the sprint board for the time being.

Daimona moved this task from Backlog to Small Items Backlog on the Connection-Team board.Jan 20 2025, 1:24 PM
Daimona updated the task description. (Show Details)
gerritbot added a comment.Mar 6 2025, 11:28 PM

Change #1125248 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Avoid non-static data providers

https://gerrit.wikimedia.org/r/1125248

gerritbot added a project: Patch-For-Review.Mar 6 2025, 11:28 PM
gerritbot added a comment.Mar 7 2025, 3:11 PM

Change #1125248 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Avoid non-static data providers

https://gerrit.wikimedia.org/r/1125248

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2025, 3:31 PM
gerritbot added a comment.Mar 7 2025, 11:35 PM

Change #1125544 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Replace more non-static data providers

https://gerrit.wikimedia.org/r/1125544

gerritbot added a project: Patch-For-Review.Mar 7 2025, 11:35 PM
gerritbot added a comment.Mar 30 2025, 8:27 PM

Change #1125544 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Replace more non-static data providers

https://gerrit.wikimedia.org/r/1125544

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2025, 8:30 PM
gerritbot added a comment.May 1 2025, 5:00 AM

Change #1140280 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140280

gerritbot added a project: Patch-For-Review.May 1 2025, 5:00 AM
gerritbot added a comment.May 1 2025, 3:30 PM

Change #1140280 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140280

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).May 1 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 4:30 PM
gerritbot added a comment.May 17 2025, 9:34 PM

Change #1147120 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1147120

gerritbot added a project: Patch-For-Review.May 17 2025, 9:34 PM
gerritbot added a comment.May 17 2025, 10:29 PM

Change #1147124 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Allow callable from provideBadTokenSessions data provider

https://gerrit.wikimedia.org/r/1147124

gerritbot added a comment.May 26 2025, 11:39 AM

Change #1147124 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Allow callable from provideBadTokenSessions data provider

https://gerrit.wikimedia.org/r/1147124

gerritbot added a comment.May 26 2025, 11:40 AM

Change #1147120 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1147120

Umherirrender mentioned this in rEWCE3d385bfa717a: tests: Allow callable from provideBadTokenSessions data provider.May 26 2025, 11:41 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 26 2025, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 26 2025, 12:30 PM
Umherirrender closed this task as Resolved.May 26 2025, 5:51 PM
gerritbot added a comment.May 27 2025, 6:56 PM

Change #1151293 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Use callable types for provideBadTokenSessions data provider

https://gerrit.wikimedia.org/r/1151293

gerritbot added a project: Patch-For-Review.May 27 2025, 6:56 PM
gerritbot added a comment.May 27 2025, 8:36 PM

Change #1151293 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Use callable types for provideBadTokenSessions data provider

https://gerrit.wikimedia.org/r/1151293

Umherirrender mentioned this in rEWCE5067d325e947: tests: Use callable types for provideBadTokenSessions data provider.May 27 2025, 8:36 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.4; 2025-06-03); removed MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 27 2025, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 27 2025, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits