Make PHPUnit dataProvider static in CampaignEvents tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 20 2023, 11:49 PM

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

EventFactoryTest with provideEventData
ArticleViewHeaderHandlerTest with provideArticle
ListParticipantsHandlerTest with provideRunData and provideRunErrors
DeleteEventCommandTest with provideRegistrationAndStore
EditEventCommandTest with providePageWithRegistrationAlreadyEnabled, provideEditUnsafeErrors` and provideEventRegistrations
EventRegistrationTest with provideInvalidTimestampFormat, provideEventsForUTCConversion and provideAmbiguousLocalTimes
EventPageCacheUpdaterTest with provideRegistrations
PageMoveAndDeleteHandlerTest with providePageDelete
CampaignsPageFactoryTest with provideTitleStrings
MWPermissionsLookupTest with provideUserHasRight, provideUserIsSitewideBlocked and provideUserIsRegistered
PageURLResolverTest with providePageAndURL
RegisterParticipantCommandTest with provideInvalidRegistrationsAndErrors, provideStoreAndModified and provideRegisterUnsafeErrors
UnregisterParticipantCommandTest with provideStoreAndModified and provideUnregisterUnsafeErrors
PermissionCheckerTest with provideCanEnableRegistrations, provideCanOrganizeEvents, provideCanEnableRegistration, provideGenericEditPermissions, provideCanDeleteRegistration and provideCanRegisterForEvents
CancelEventRegistrationHandlerTest with provideRequestDataWithErrors and provideRequestDataSuccessful
DeleteEventRegistrationHandlerTest with provideErrorData
EnableEventRegistrationHandlerTest with provideExecuteDataForValidationTest
ListEventsByOrganizerHandlerTest with provideExecuteDataForEventListingTest
ListEventsByParticipantHandlerTest with provideExecuteDataForEventListingTest
ListOrganizersHandlerTest with provideRunData
Rest\RegisterForEventHandlerTest with provideRequestDataWithErrors and provideRequestDataSuccessful
RemoveParticipantsFromEventHandlerTest with provideRequestDataWithErrors and provideRequestDataSuccessful
Rest\SetOrganizersHandlerTest with provideCommandErrors
UpdateEventRegistrationHandlerTest with provideExecuteDataForValidationTest
EventTimeFormatterTest with provideDates and provideTimezones

static and adjust the usages (More infos at T332865).

Initial work was done in 4d745381debfe28cbea15e67be50534624e675be

Details

	Subject	Repo	Branch	Lines +/-
	tests: Make remaining data providers static in PermissionCheckerTest	mediawiki/extensions/CampaignEvents	master	+131 -125
	tests: Make data providers static in PermissionCheckerTest, part 1	mediawiki/extensions/CampaignEvents	master	+232 -152

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Open	None	T337166 Make PHPUnit dataProvider static in CampaignEvents tests

Event Timeline

Umherirrender created this task.May 20 2023, 11:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2023, 11:49 PM

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 11:49 PM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:30 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

Daimona moved this task from Backlog to Tech debt on the CampaignEvents board.Nov 10 2023, 6:02 PM

Change #1050067 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Make data providers static in PermissionCheckerTest, part 1

https://gerrit.wikimedia.org/r/1050067

Change #1050073 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] tests: Make remaining data providers static in PermissionCheckerTest

https://gerrit.wikimedia.org/r/1050073

Change #1050067 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make data providers static in PermissionCheckerTest, part 1

https://gerrit.wikimedia.org/r/1050067

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Fri, Jun 28, 10:00 PM

Change #1050073 merged by jenkins-bot: