Maniphest T337309

🏷️🐼 Validate type of the value field
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	May 23 2023, 1:30 PM

Tags

Referenced Files

None

Subscribers

• Muhammad_Yasser_Jazirahly_WMDE

Ollie.Shotton_WMDE

• WMDE_Norman

Description

The new value of labels to be patched must be a string. Currently, non-string label values cause a 500 error due to failed deserialization.

Instead, an InvalidFieldExceptionshould be thrown, resulting in http status code 422 with the following response :

{
"code": "patched-label-invalid"
"message": "Changed label for '{lang_code}' is not valid: '{label-text}'"
"context": {
  "language": <language_code>
  "value": <label>
}

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Handle non-string JSON Patch 'value' fields	mediawiki/extensions/Wikibase	master	+62 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T344228 Functionality for REST API v1
		Resolved		WMDE-leszek	T332739 🏷️🐼 Modify data of labels of an item
		Resolved		Silvan_WMDE	T337309 🏷️🐼 Validate type of the value field

Event Timeline

Silvan_WMDE created this task.May 23 2023, 1:30 PM

Silvan_WMDE updated the task description. (Show Details)May 23 2023, 1:41 PM

Silvan_WMDE claimed this task.May 24 2023, 7:36 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 29) board.

Silvan_WMDE updated the task description. (Show Details)May 24 2023, 7:54 AM

Change 922817 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Handle non-string JSON Patch 'value' fields

https://gerrit.wikimedia.org/r/922817

gerritbot added a project: Patch-For-Review.May 24 2023, 11:12 AM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 29) board.May 24 2023, 11:34 AM

Jakob_WMDE closed this task as Resolved.May 24 2023, 1:43 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 29) board.

Change 922817 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle non-string JSON Patch 'value' fields

https://gerrit.wikimedia.org/r/922817

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 24 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 24 2023, 2:10 PM