| jrbs | |
| May 27 2023, 12:13 AM |
| F37079877: image.png | |
| May 27 2023, 5:16 AM |
| F37079875: image.png | |
| May 27 2023, 5:16 AM |
| F37079873: image.png | |
| May 27 2023, 5:16 AM |
| F37079684: screenshot.446.jpg | |
| May 27 2023, 12:15 AM |
Steps to replicate the issue (include links if applicable):
Reproducible on commonswiki & loginwiki
What happens?:
What should have happened instead?:
The software should prompt that the user has no data within the time window (as it does for "Get IP addresses")
Re-producable for 'Get edits' locally. Also found the issue (I think):
return $this->getCheckUserHelperFieldset()->getHTML( false );
The getCheckUserHelperFieldset() method returns null when there are no edits, so this should have checked for null.
Only occurs when a user or IP has no results and while running 'get edits'/'get users'
Change 923723 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Check for null when using ::getCheckUserHelperFieldset
This issue also does not prevent logging of the check on my local environment:
The above patch fixes this issue.
Based on the above (not preventing logging), I think it should be fine for this to be an issue until the next train rolls around. This (in summary) is because:
Change 923723 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Check for null when using ::getCheckUserHelperFieldset
Change 923635 had a related patch set uploaded (by Zabe; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.10] Check for null when using ::getCheckUserHelperFieldset
Change 923635 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.10] Check for null when using ::getCheckUserHelperFieldset
Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:42:10Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:923635|Check for null when using ::getCheckUserHelperFieldset (T337599)]]
Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:43:48Z] <zabe@deploy1002> zabe: Backport for [[gerrit:923635|Check for null when using ::getCheckUserHelperFieldset (T337599)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:52:03Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:923635|Check for null when using ::getCheckUserHelperFieldset (T337599)]] (duration: 09m 52s)
Looks like this can be closed as the change seems to be on all wikis now (just tested it on the English Wikipedia when processing a sockpuppets investigation case).