UnexpectedValueException: Unknown image suggestions API kind: istype-section-topics
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	TheresNoTime
	May 29 2023, 10:28 PM

Description

Error

mwversion: 1.41.0-wmf.10
reqId: 3d7e8eaf-e1a7-42b6-9d48-2e300a1cb300
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   UnexpectedValueException: Unknown image suggestions API kind: istype-section-topics

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ProductionImageRecommendationApiHandler.php(139)
#0 /srv/mediawiki/php-1.41.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(126): GrowthExperiments\NewcomerTasks\AddImage\ProductionImageRecommendationApiHandler->getSuggestionDataFromApiResponse(array, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#1 /srv/mediawiki/php-1.41.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(90): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(MediaWiki\Title\Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#2 /srv/mediawiki/php-1.41.0-wmf.10/includes/libs/objectcache/wancache/WANObjectCache.php(1731): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::GrowthExperiments\NewcomerTasks\AddImage\{closure}(boolean, integer, array, NULL, array)
#3 /srv/mediawiki/php-1.41.0-wmf.10/includes/libs/objectcache/wancache/WANObjectCache.php(1561): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#4 /srv/mediawiki/php-1.41.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(95): WANObjectCache->getWithSetCallback(string, integer, Closure)
#5 /srv/mediawiki/php-1.41.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSetListener.php(58): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::getWithSetCallback(WANObjectCache, GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType, TitleValue, string, BufferingStatsdDataFactory)
#6 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/MWCallableUpdate.php(38): GrowthExperiments\NewcomerTasks\TaskSetListener->GrowthExperiments\NewcomerTasks\{closure}()
#7 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdates.php(473): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdates.php(398): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#9 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdates.php(213): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
#10 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#11 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#12 /srv/mediawiki/php-1.41.0-wmf.10/includes/deferred/DeferredUpdates.php(234): DeferredUpdatesScope->processUpdates(integer, Closure)
#13 /srv/mediawiki/php-1.41.0-wmf.10/includes/MediaWiki.php(1125): DeferredUpdates::doUpdates()
#14 /srv/mediawiki/php-1.41.0-wmf.10/includes/MediaWiki.php(856): MediaWiki->restInPeace()
#15 /srv/mediawiki/php-1.41.0-wmf.10/api.php(128): MediaWiki->doPostOutputShutdown()
#16 /srv/mediawiki/php-1.41.0-wmf.10/api.php(48): wfApiMain()
#17 /srv/mediawiki/w/api.php(3): require(string)
#18 {main}

Impact

Notes

~20 in the last hour, something in the back of my head is recalling that section images (?) were recently deployed?

Details

Request URL: https://fr.wikipedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	Section images: Accept all API response 'kind' fields	mediawiki/extensions/GrowthExperiments	master	+100 -23

Customize query in gerrit

Related Objects

Mentioned Here: T329278: Section-level images: Create tooling to mock API

Event Timeline

TheresNoTime created this task.May 29 2023, 10:28 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 29 2023, 10:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We're discussing whether to log these exceptions in this patch, which is tagged against T329278: Section-level images: Create tooling to mock API.

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 30 2023, 10:22 AM

Change 924169 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Accept all API response 'kind' fields

https://gerrit.wikimedia.org/r/924169

gerritbot added a project: Patch-For-Review.May 30 2023, 3:23 PM

Change 924169 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Accept all API response 'kind' fields

https://gerrit.wikimedia.org/r/924169

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 4:10 PM

@Tgr - I'm cleaning up old tasks on our Sprint board. It sounds like you worked on this:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/924169

Should I assign this task to you and mark it as resolved? Or should we keep this open?

Yeah this should be fixed.

UnexpectedValueException: Unknown image suggestions API kind: istype-section-topicsClosed, ResolvedPublicPRODUCTION ERRORActions