Page MenuHomePhabricator

Remove is_oversample feature in the Navigation Timing extension
Closed, ResolvedPublic

Description

There is nothing that we use from the oversampling feature today, and the move to Prometheus removes most of the need for it since we no longer "need" to have large amounts of data every single minute in order to have meaninful aggregates (in Prometheus we can summarise buckets over larger time spans instead).

There's a couple of things to be done here:

  • Remove JavaScript code in the MediaWiki-NavigationTiming extension for oversampling.
  • Remove config and package file export for oversampling in MediaWiki-NavigationTiming extension.
  • Remove unused NavigationTiming config values in wmf-config.
  • Make sure we use the same sample rates for NavigationTiming in wmf-config for all wikis.

Keep the schema as is for now, so if we need it in the future, it easy to add back.

Event Timeline

Change 925548 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/extensions/NavigationTiming@master] Remove oversample functionality.

https://gerrit.wikimedia.org/r/925548

Change 925548 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Remove oversample functionality.

https://gerrit.wikimedia.org/r/925548

Change 930711 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/extensions/NavigationTiming@master] Remove oversample config.

https://gerrit.wikimedia.org/r/930711

Change 930712 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[operations/mediawiki-config@master] Remove oversampling for Navigation Timing extension.

https://gerrit.wikimedia.org/r/930712

Change 930711 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Remove oversample config.

https://gerrit.wikimedia.org/r/930711

Change 930712 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove oversampling for Navigation Timing extension.

https://gerrit.wikimedia.org/r/930712

Mentioned in SAL (#wikimedia-operations) [2023-07-11T15:21:21Z] <krinkle@deploy1002> Started scap: Backport for [[gerrit:930712|Remove oversampling for Navigation Timing extension. (T337858)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-11T15:22:53Z] <krinkle@deploy1002> phedenskog and krinkle: Backport for [[gerrit:930712|Remove oversampling for Navigation Timing extension. (T337858)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-11T16:03:21Z] <Lucas_WMDE> previous backport also included [[gerrit:930712|Remove oversampling for Navigation Timing extension. (T337858)]]

Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)