Page MenuHomePhabricator

Drop campaign_events.event_tracking_tool_id and campaign_events.event_tracking_tool_event_id
Closed, ResolvedPublic

Description

The CampaignEvents extension now uses a separate table (ce_tracking_tools, see T334143) to store tracking tools. As part of the migration (T336364), we need to drop the old columns. Note that these columns are not used yet, so they should only contain NULL values and can be dropped safely.

ALTERs to run:

ALTER TABLE campaign_events DROP COLUMN event_tracking_tool_id, DROP COLUMN event_tracking_tool_event_id;
  1. Where to run those changes: The table is in the extension1 cluster. There, it can be found in the per-wiki databases of testwiki, test2wiki, and officewiki, as well as in the wikishared database. So it's a total of 4 places.
  2. When to run those changes: After deployment of 1.41.0-wmf.12, next week
  3. If the schema change is backwards compatible: Yes
  4. If the schema change has been tested already on some of the test/beta wikis: Tested locally and in beta (T336362)
  5. if the data should be made available on the labs replicas and/or dumps: while we don't replicate data from x1, these columns are currently configured as public. Said configuration should be removed from https://gerrit.wikimedia.org/g/operations/puppet/+/2bf88ad0f7c6e1c54fd278c9568b55cd2e3c69f9/modules/role/files/mariadb/filtered_tables.txt#198

Progress:

  • testwiki (x1)
  • test2wiki (x1)
  • officewiki (x1)
  • wikishared (x1)

Event Timeline

I guess this can be ran with replication on master. The table should be quite small

Change 925921 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/puppet@production] filtered_tables.txt: Update for CampaignEvents schema change

https://gerrit.wikimedia.org/r/925921

(Just noting that wmf.12 is everywhere now and it likely won't get rolled back, so this is unblocked.)

Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to In progress on the DBA board.
Marostegui updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2023-06-13T05:48:40Z] <marostegui> dbmaint Deploy schema change on x1 eqiad with replication T337940

Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)

This is done

Change 929604 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Remove event_tracking_tool_*

https://gerrit.wikimedia.org/r/929604

Change 929604 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Remove event_tracking_tool_*

https://gerrit.wikimedia.org/r/929604